All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] tst_kconfig: Add CONFIG_* mappings for keyctl tests
Date: Tue, 22 Sep 2026 14:28:16 +0000	[thread overview]
Message-ID: <20260922142816.4918-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260922122059.4087109-1-chrubis@suse.cz>

Hi Cyril,

On Tue Sep 22 14:20:59 2026 +0200, Cyril Hrubis wrote:
> tst_kconfig: Add CONFIG_* mappings for keyctl tests

> @@ -165,6 +165,8 @@ static struct config_module_map {
>  	{"CONFIG_NET_SCH_INGRESS", "sch_ingress"},
>  	{"CONFIG_NET_CLS_MATCHALL", "cls_matchall"},
>  	{"CONFIG_NET_ACT_PEDIT", "act_pedit"},
> +	{"CONFIG_PKCS8_PRIVATE_KEY_PARSER", "pcks8_key_parser"},

Typo in module name "pcks8_key_parser"; change it to "pkcs8_key_parser".
When CONFIG_PKCS8_PRIVATE_KEY_PARSER=m, tst_check_module_driver() fails
to find the module and marks the kconfig as unset, causing tests like
keyctl30 to be incorrectly skipped with TCONF.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-09-22 14:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 12:20 [LTP] [PATCH] tst_kconfig: Add CONFIG_* mappings for keyctl tests Cyril Hrubis
2026-09-22 14:28 ` linuxtestproject.agent [this message]
2026-09-22 15:11   ` [LTP] " Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922142816.4918-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.