From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: mfd@lists.linux.dev, lee@kernel.org, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v13 2/2] mfd: ac200: Add X-Powers AC200 support
Date: Tue, 22 Sep 2026 16:40:04 +0000 [thread overview]
Message-ID: <20260922164005.217BD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922-submit-ac200-mfd-v13-2-8832afd2481c@gmail.com>
> The X-Powers AC200 is a mixed-signal companion IC with a paged register
> map accessed over I2C.
>
> Enable and rate-lock the shared input clock, retain the vendor resume
> path's 40 ms wait before creating the regmap and accessing registers, and
> deassert the common reset. No minimum delay is documented. Set only the
> deassert bit instead of forcing a reset cycle, avoiding a chip-wide reset
> of unrelated function registers. Leave the common reset deasserted during
> driver removal and system shutdown; function drivers own their block
> resets. Supplier unbind still tears down linked consumers and releases
> the provider's clock references.
>
> Cache only the common page selector. Individual functions can reset
> independently and invalidate their other registers, so leave all
> functional registers volatile.
> [ ... ]
> ancillary package-control access.
>
> Co-developed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-submit-ac200-mfd-v13-0-8832afd2481c@gmail.com?part=2
next prev parent reply other threads:[~2026-09-22 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 16:34 [PATCH v13 0/2] mfd: add X-Powers AC200 support James Hilliard
2026-09-22 16:34 ` [PATCH v13 1/2] dt-bindings: mfd: x-powers: Add AC200 James Hilliard
2026-09-22 16:37 ` sashiko-bot
2026-09-22 16:34 ` [PATCH v13 2/2] mfd: ac200: Add X-Powers AC200 support James Hilliard
2026-09-22 16:40 ` sashiko-bot [this message]
2026-09-29 10:16 ` [PATCH v13 0/2] mfd: add " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922164005.217BD1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.