From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 478FBC98302 for ; Tue, 22 Sep 2026 17:18:21 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 595593E6D35 for ; Tue, 22 Sep 2026 19:18:20 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E68A13E1628 for ; Tue, 22 Sep 2026 19:18:03 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 83EBD1400DFD for ; Tue, 22 Sep 2026 19:18:02 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 474ED1F822; Tue, 22 Sep 2026 17:18:01 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D806D1365D; Tue, 22 Sep 2026 17:18:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id C/4HJki4smovbwAAD6G6ig (envelope-from ); Tue, 22 Sep 2026 17:18:00 +0000 Date: Tue, 22 Sep 2026 19:17:59 +0200 From: Petr Vorel To: Avinesh Kumar Message-ID: <20260922171759.GA2287170@pevik> References: <20260922153803.257734-1-avinesh.kumar@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260922153803.257734-1-avinesh.kumar@suse.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 474ED1F822 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Virus-Scanned: clamav-milter 1.0.9 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] bpf_map01: Fix inverted condition for array map lookup pass X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Avinesh, > The check "if (i < VAL_SZ)" after the zero-value scan loop is > backwards: it fires TPASS only when the loop broke early (i.e. > a non-zero byte was found and TFAIL already reported), and stays > silent when the loop completes normally with all zeros as expected. > Report TPASS when i == VAL_SZ instead. Thanks for an obvious fix, merged! Kind regards, Petr > Fixes: b51732825077 ("BPF: Sanity check creating and updating maps") > Signed-off-by: Avinesh Kumar > --- > testcases/kernel/syscalls/bpf/bpf_map01.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/testcases/kernel/syscalls/bpf/bpf_map01.c b/testcases/kernel/syscalls/bpf/bpf_map01.c > index 7fcf8e00fe4e..97cebf6bf6f3 100644 > --- a/testcases/kernel/syscalls/bpf/bpf_map01.c > +++ b/testcases/kernel/syscalls/bpf/bpf_map01.c > @@ -82,7 +82,7 @@ void run(unsigned int n) > break; > } > } > - if (i < VAL_SZ) > + if (i == VAL_SZ) > tst_res(TPASS, "Preallocated array map lookup"); > } else { > tst_res(TFAIL | TTERRNO, "Prellocated array map lookup"); -- Mailing list info: https://lists.linux.it/listinfo/ltp