Re: [PATCH net v6] net: Wangxun: protect ring accesses with RCU

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 22 Sep 2026 16:48:16 +0800 mengyuanlou@net-swift.com wrote:
> Sorry about that. I’ll fix both issues in the next revision and make sure to
> address the previous review comments more carefully.
> Thanks.
> 
> Another question:
> 
> wx_init_interrupt_scheme() → 
> wx_lib.c:2392 wx_cache_ring_rss() → 
> wx_lib.c: rcu_dereference_protected(..., lockdep_rtnl_is_held())
> 
> When wx_init_interrupt_scheme is in xxx_probe, unlike other txgbe_setup_tc
> and ngbe_resume, at this point the netdev has not yet been registered.
> 
> +rtnl_lock();
> err = wx_init_interrupt_scheme(wx);
> +rtnl_unlock();
> if (err)
> goto err_cancel_service;
> 
> At this point, rntl_lock is merely used to address RCU_LOCKDEP_WARN.
> Is this approach appropriate?

I think that's acceptable. Maybe add a comment as well just to make it
clear why we're taking the lock.