From: Jakub Kicinski <kuba@kernel.org>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Sabrina Dubroca <sd@queasysnail.net>,
netdev@vger.kernel.org,
Martin Belanger <martin.belanger@dell.com>
Subject: Re: [PATCH 2/2] tls: return a distinct error for control records from read_sock
Date: Tue, 22 Sep 2026 17:56:51 -0700 [thread overview]
Message-ID: <20260922175651.3ce5d18f@kernel.org> (raw)
In-Reply-To: <20260922133708.84522-3-hare@kernel.org>
On Tue, 22 Sep 2026 15:37:08 +0200 Hannes Reinecke wrote:
> tls_sw_read_sock() leaves a non-data record on the receive list and
> returns -EINVAL. The same function returns -EINVAL when an sk_psock is
> attached, and an actor may return it for other reasons, so callers
> cannot determine whether a control record is waiting.
>
> Return -EPROTO instead. The record can then be read with recvmsg()
> and a control buffer, which reports its type.
Please run the selftests.
--
pw-bot: cr
prev parent reply other threads:[~2026-09-23 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 13:37 [PATCH 0/2] nvme,tls: minimal handling for TLS records Hannes Reinecke
2026-09-22 13:37 ` [PATCH 1/2] nvme-tcp: start error recovery when read_sock fails Hannes Reinecke
2026-09-22 13:37 ` [PATCH 2/2] tls: return a distinct error for control records from read_sock Hannes Reinecke
2026-09-23 0:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922175651.3ce5d18f@kernel.org \
--to=kuba@kernel.org \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.belanger@dell.com \
--cc=netdev@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.