From: Thorsten Blum <blum@kernel.org>
To: Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Kees Cook <kees@kernel.org>, Michael Buesch <mb@bu3sch.de>,
Andrew Morton <akpm@osdl.org>, Jan Beulich <jbeulich@novell.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Chris Wright <chrisw@sous-sol.org>
Cc: Thorsten Blum <blum@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] hwrng: intel - return -ENOMEM when ioremap() fails
Date: Tue, 22 Sep 2026 20:11:01 +0200 [thread overview]
Message-ID: <20260922181102.67309-3-blum@kernel.org> (raw)
intel_init_hw_struct() incorrectly returns -EBUSY when ioremap() fails.
Return -ENOMEM instead.
Fixes: 641dd002d207 ("[PATCH] fix Intel RNG detection")
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/char/hw_random/intel-rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/intel-rng.c b/drivers/char/hw_random/intel-rng.c
index d24e747203c1..a4dd21a9de98 100644
--- a/drivers/char/hw_random/intel-rng.c
+++ b/drivers/char/hw_random/intel-rng.c
@@ -318,8 +318,8 @@ PFX "RNG, try using the 'no_fwh_detect' option.\n";
}
intel_rng_hw->mem = ioremap(INTEL_FWH_ADDR, INTEL_FWH_ADDR_LEN);
- if (intel_rng_hw->mem == NULL)
- return -EBUSY;
+ if (!intel_rng_hw->mem)
+ return -ENOMEM;
return 0;
}
next reply other threads:[~2026-09-22 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 18:11 Thorsten Blum [this message]
2026-09-22 18:11 ` [PATCH 2/2] hwrng: intel - return -ENOMEM when kmalloc_obj() fails Thorsten Blum
2026-10-02 8:25 ` Herbert Xu
2026-10-02 7:21 ` [PATCH 1/2] hwrng: intel - return -ENOMEM when ioremap() fails Herbert Xu
2026-10-02 8:31 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922181102.67309-3-blum@kernel.org \
--to=blum@kernel.org \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=jbeulich@novell.com \
--cc=kees@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.