From: linuxtestproject.agent@gmail.com
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] lapi/keyctl.h: Remove <keyutils.h>
Date: Tue, 22 Sep 2026 18:40:07 +0000 [thread overview]
Message-ID: <20260922184007.13630-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260922160911.2271754-2-pvorel@suse.cz>
Hi Cyril,
On Tue Sep 22 18:09:08 2026 +0200, Cyril Hrubis wrote:
> lapi/keyctl.h: Remove <keyutils.h>
--- [PATCH 4/4] ---
> Follow-up: bc8ead0f06 ("lapi/keyctl.h: Remove <keyutils.h>")
Commit hash bc8ead0f06 does not exist in the repository. It refers to
patch 1 in this series (875e1f2966dc).
> LTP_CHECK_FORTIFY_SOURCE
> LTP_CHECK_KERNEL_DEVEL
> -LTP_CHECK_KEYUTILS_SUPPORT
> LTP_CHECK_LIBMNL
Removing LTP_CHECK_KEYUTILS_SUPPORT leaves the LIBRARIES summary in
configure.ac printing "keyutils: yes" unconditionally. Also remove
"keyutils: ${have_keyutils:-yes}" from the summary and "keyutils.h"
from AC_CHECK_HEADERS_ONCE.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-22 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 16:09 [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
2026-09-22 18:40 ` linuxtestproject.agent [this message]
2026-09-23 5:33 ` [LTP] " Petr Vorel
2026-09-23 9:15 ` [LTP] [PATCH 1/4] " Li Wang
2026-09-23 10:27 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv' Petr Vorel
2026-09-23 9:26 ` Li Wang
2026-09-23 10:28 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check Petr Vorel
2026-09-23 9:52 ` Li Wang
2026-09-23 19:35 ` Petr Vorel
2026-09-23 10:29 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 4/4] Remove libkeyutils use Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922184007.13630-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.