Re: [PATCH v3 14/14] audit: rename audit_syscall_entry_regs() to audit_syscall_entry()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: alpha fails to compile due to unconverted audit_syscall_entry()
--

commit ec0fa766c1abca8ff2e93429fedc5d6b95059a19
Author: Ricardo Robaina <rrobaina@redhat.com>

audit: rename audit_syscall_entry_regs() to audit_syscall_entry()

Now that every architecture has been converted to the pt_regs-based
audit_syscall_entry_regs(), the legacy audit_syscall_entry() and
__audit_syscall_entry() helpers that took the individual syscall
argument registers (a0-a3) no longer have any callers.

Remove those legacy helpers and rename audit_syscall_entry_regs() and
__audit_syscall_entry_regs() back to audit_syscall_entry() and
__audit_syscall_entry(), restoring the original naming.

[ ... ]

> diff --git a/include/linux/audit.h b/include/linux/audit.h
> index 22ffad5b20608..9ce5962bc5370 100644
> --- a/include/linux/audit.h
> +++ b/include/linux/audit.h
> @@ -374,17 +372,10 @@ static inline void audit_uring_exit(int success, long code)
>  	if (unlikely(audit_context()))
>  		__audit_uring_exit(success, code);
>  }
> -static inline void audit_syscall_entry(int major, unsigned long a0,
> -				       unsigned long a1, unsigned long a2,
> -				       unsigned long a3)
> +static inline void audit_syscall_entry(int major, struct pt_regs *regs)
>  {

[Severity: Low]
The commit message states that every architecture has been converted, but does
this break the build for the Alpha architecture?

Looking at arch/alpha/kernel/ptrace.c:syscall_trace_enter(), there is still an
unconverted caller that passes 5 arguments to audit_syscall_entry():

arch/alpha/kernel/ptrace.c:syscall_trace_enter() {
	...
#ifdef CONFIG_AUDITSYSCALL
	audit_syscall_entry(syscall_get_nr(current, regs),
		regs->r16, regs->r17, regs->r18, regs->r19);
#endif
	...
}

Since the 5-argument helper has been removed and the renamed helper now
expects exactly 2 arguments, will this cause a 'too many arguments to
function' compilation error when building for Alpha?

>  	if (unlikely(audit_context()))
> -		__audit_syscall_entry(major, a0, a1, a2, a3);
> -}
> -static inline void audit_syscall_entry_regs(int major, struct pt_regs *regs)
> -{
> -	if (unlikely(audit_context()))
> -		__audit_syscall_entry_regs(major, regs);
> +		__audit_syscall_entry(major, regs);
>  }
>  static inline void audit_syscall_exit(void *pt_regs)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790088067.git.rrobaina@redhat.com?part=14