From: sashiko-bot@kernel.org
To: "Sunny Tiwari" <sunnytiwari@google.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next] net/rds: replace tasklets with workqueue
Date: Tue, 22 Sep 2026 21:03:14 +0000 [thread overview]
Message-ID: <20260922210314.9CADD1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <6b07af04b3ba66a09009e1a0a7b98ec5ec85d3a0.1790109248.git.sunnytiwari@google.com>
> tasklet_struct is deprecated. Convert the send and receive completion
> handlers in net/rds/ib to work items on a dedicated high-priority
> workqueue.
>
> Allocate per-CPU bound rds_ib_wq with WQ_HIGHPRI | WQ_MEM_RECLAIM in
> rds_ib_init() and destroy it in rds_ib_exit(). Per-CPU binding preserves
> cache locality with the completion vector, matching original tasklet
> affinity without cross-core migration.
>
> Replace i_send_tasklet and i_recv_tasklet with struct work_struct. Order
> quiescence via atomic_set_release() and atomic_read_acquire() prior to
> cancel_work_sync() during connection shutdown.
>
> Assisted-by: Gemini
> Signed-off-by: Sunny Tiwari <sunnytiwari@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/6b07af04b3ba66a09009e1a0a7b98ec5ec85d3a0.1790109248.git.sunnytiwari@google.com?part=1
next prev parent reply other threads:[~2026-09-22 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 20:52 [PATCH net-next] net/rds: replace tasklets with workqueue Sunny Tiwari
2026-09-22 21:03 ` sashiko-bot [this message]
2026-09-25 9:24 ` [syzbot ci] " syzbot ci
-- strict thread matches above, loose matches on Subject: below --
2026-09-25 8:53 [PATCH net-next] " netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922210314.9CADD1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sunnytiwari@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.