From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] regulator: dt-bindings: Add MAX20024 sd4
Date: Tue, 22 Sep 2026 21:30:19 +0000 [thread overview]
Message-ID: <20260922213020.4C78D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922212140.1118832-1-robh@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: missing MAX77663 in sd4 regulator documentation
--
commit 6ef52d57b8dafa6b7fbd7ddad9b91b83cd6fe092
Author: Rob Herring (Arm) <robh@kernel.org>
regulator: dt-bindings: Add MAX20024 sd4
Allow the MAX20024 extra sd4 regulator and its in-sd4 supply in the
MAX77620 regulator schema.
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml b/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
> index 7118c34961ba0..0f2901cab8afe 100644
> --- a/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
> @@ -10,17 +10,17 @@ maintainers:
> - Svyatoslav Ryhel <clamor95@gmail.com>
>
> description:
> - Device has multiple DCDC(sd[0-3]) and LDOs(ldo[0-8]). The input supply
> - of these regulators are defined under parent device node. Details of
> - regulator properties are defined as child node under sub-node "regulators"
> - which is child node of device node.
> + Device has multiple DCDC (sd[0-3], plus sd4 on MAX20024) and LDOs
[Severity: Low]
Does this description omit MAX77663?
The driver code (drivers/regulator/max77620-regulator.c) defines sd4 for
max77663_regs_info, and maxim,max77663 is a supported compatible string that
utilizes this regulator schema via mfd/maxim,max77620.yaml. Omitting it from
the updated description string creates an inaccuracy regarding which hardware
variants support the sd4 regulator.
> + (ldo[0-8]). The input supply of these regulators are defined under parent
> + device node. Details of regulator properties are defined as child node under
> + sub-node "regulators" which is child node of device node.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922212140.1118832-1-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-09-22 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 21:21 [PATCH] regulator: dt-bindings: Add MAX20024 sd4 Rob Herring (Arm)
2026-09-22 21:30 ` sashiko-bot [this message]
2026-09-23 9:01 ` Svyatoslav Ryhel
2026-09-23 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922213020.4C78D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.