Re: [PATCH v3 2/5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: mfd: qcom,spmi-pmic: schema validation regression for wcd codecs
- [Low] dt-bindings: mfd: qcom,spmi-pmic: typo in commit title (pm4124 vs pm4125)
--

commit aa39b4a36b271ce733e772eaf378517309e2b1c7
Author: Alexey Klimov <alexey.klimov@linaro.org>

dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

This commit adds the missing qcom,pm4125-codec compatible string to the
audio-codec node pattern properties in the mfd qcom,spmi-pmic schema to
support the audio codec on the Qualcomm Agatti SoC.

> dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec

This isn't a bug, but there is a typo in the commit subject. The title refers
to pm4124-codec, while the commit body and the actual compatible string added
in the patch use qcom,pm4125-codec.

> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index f6534e9e9912e..d750da31ae3f5 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -148,7 +148,15 @@ patternProperties:
>  
>    "^audio-codec@[0-9a-f]+$":
>      type: object
> -    $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
> +    properties:
> +      compatible:
> +        contains:
> +          enum:
> +            - qcom,pm4125-codec
> +            - qcom,pm8916-wcd-analog-codec

[Severity: Medium]
Does replacing the $ref with a restricted enum block incorrectly limit the
allowed compatible strings? Devices using standalone compatibles like
qcom,pm8950-wcd-analog-codec or qcom,pm8953-wcd-analog-codec, which were
legally permitted by the child schema, will now fail validation against
qcom,spmi-pmic.yaml when running make dtbs_check.

> +
> +    required:
> +      - compatible

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790114902.git.srinivas.kandagatla@oss.qualcomm.com?part=2