From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,osalvador@suse.de,muchun.song@linux.dev,david@kernel.org,zhenghui.hao@qq.com,akpm@linux-foundation.org
Subject: + hugetlbfs-fix-stale-comment-in-hugetlbfs_file_mmap.patch added to mm-unstable branch
Date: Tue, 22 Sep 2026 19:46:47 -0700 [thread overview]
Message-ID: <20260923024647.92FC31F000FF@smtp.kernel.org> (raw)
The patch titled
Subject: hugetlbfs: fix stale comment in hugetlbfs_file_mmap()
has been added to the -mm mm-unstable branch. Its filename is
hugetlbfs-fix-stale-comment-in-hugetlbfs_file_mmap.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/hugetlbfs-fix-stale-comment-in-hugetlbfs_file_mmap.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Zhenghui Hao <zhenghui.hao@qq.com>
Subject: hugetlbfs: fix stale comment in hugetlbfs_file_mmap()
Date: Wed, 23 Sep 2026 10:28:58 +0800
The comment above the VMA flag setup in hugetlbfs_file_mmap() says the VMA
address alignment has already been checked by prepare_hugepage_range().
That function no longer exists: it was removed by commit eff41389d824
("mm/hugetlb: remove prepare_hugepage_range()"), and the check now lives
in hugetlb_get_unmapped_area().
The comment also mentions ia64, which was removed from the tree by commit
cf8e8658100d ("arch: Remove Itanium (IA-64) architecture").
Point the comment at the current function and drop the ia64 reference.
The rest of the comment, which tells future edits to add any error return
only after VM_HUGETLB has been set, is still accurate and is left
untouched.
No functional change.
Link: https://lore.kernel.org/tencent_AA61551D1F50E61F46C8542F5C8874512C05@qq.com
Signed-off-by: Zhenghui Hao <zhenghui.hao@qq.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Muchun Song <muchun.song@linux.dev>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: David Hildenbrand <david@kernel.org>
---
fs/hugetlbfs/inode.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--- a/fs/hugetlbfs/inode.c~hugetlbfs-fix-stale-comment-in-hugetlbfs_file_mmap
+++ a/fs/hugetlbfs/inode.c
@@ -106,11 +106,10 @@ static int hugetlbfs_file_mmap(struct fi
/*
* vma address alignment (but not the pgoff alignment) has
- * already been checked by prepare_hugepage_range. If you add
- * any error returns here, do so after setting VM_HUGETLB, so
- * vma_is_hugetlb tests below unmap_region go the right
- * way when do_mmap unwinds (may be important on powerpc
- * and ia64).
+ * already been checked by hugetlb_get_unmapped_area(). If you
+ * add any error returns here, do so after setting VM_HUGETLB,
+ * so vma_is_hugetlb tests below unmap_region go the right
+ * way when do_mmap unwinds (may be important on powerpc).
*/
vma_set_flags(vma, VMA_HUGETLB_BIT, VMA_DONTEXPAND_BIT);
vma->vm_ops = &hugetlb_vm_ops;
_
Patches currently in -mm which might be from zhenghui.hao@qq.com are
mm-hugetlb-fix-misspelled-parameter-names-in-comment.patch
hugetlbfs-fix-stale-comment-in-hugetlbfs_file_mmap.patch
reply other threads:[~2026-09-23 2:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923024647.92FC31F000FF@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=zhenghui.hao@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.