Re: [PATCH v7 12/14] media: mediatek: vcodec: clean xpc status

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] media: mediatek: wrong enum type used to index main_dev->reg_base array
--

commit c332070b6bf8a16fa63f12155e0ac06b323d2142
Author: Kyrie Wu <kyrie.wu@mediatek.com>

media: mediatek: vcodec: clean xpc status

The driver need to clean xpc status when receive decoder hardware
interrupt for mt8196 platform.

> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_hw.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_hw.c
> index 881d5de41e050..46ac3e41c401c 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_hw.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_hw.c

[ ... ]

> @@ -166,6 +196,7 @@ static int mtk_vdec_hw_probe(struct platform_device *pdev)
>  	subdev_dev->hw_idx = hw_idx;
>  	subdev_dev->main_dev = main_dev;
>  	subdev_dev->reg_base[VDEC_HW_SYS] = main_dev->reg_base[VDEC_HW_SYS];
> +	subdev_dev->reg_base[VDEC_HW_XPC] = main_dev->reg_base[VDEC_HW_MISC];
                                                                     ^^^^^^^^^^^^

[Severity: Low]
Is the wrong enum type used here to index main_dev->reg_base?

The array main_dev->reg_base is explicitly sized by NUM_MAX_VCODEC_REG_BASE
and expects to be indexed by enum mtk_hw_reg_idx (which includes VDEC_MISC).
However, this line uses VDEC_HW_MISC, which belongs to enum
mtk_vdec_hw_reg_idx.

While both VDEC_MISC and VDEC_HW_MISC happen to evaluate to 1, avoiding an
out-of-bounds fault or incorrect register access today, this cross-enum
type mismatch creates a logic flaw that could be fragile if the enums change
in the future.

>  	set_bit(subdev_dev->hw_idx, main_dev->subdev_bitmap);
>  
>  	if (IS_SUPPORT_VDEC_HW_IRQ(hw_idx)) {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923024258.257846-1-kyrie.wu@mediatek.com?part=12