All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qihang <q.h.hack.winter@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
	stable@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net v2] xfrm: validate ihl in xfrm4_transport_output()
Date: Wed, 23 Sep 2026 11:28:40 +0800	[thread overview]
Message-ID: <20260923032840.46294-1-q.h.hack.winter@gmail.com> (raw)
In-Reply-To: <arM4SS7k7aswJAOL@gondor.apana.org.au>

On Wed, Sep 23, 2026 at 12:24:09PM +1000, Herbert Xu wrote:
> As I said when this first came up, our entire IPv4 stack
> assumes that this is validated upon entry into the IP stack.
>
> So taking a whack-a-mole approach inside the IPv4 stack is the
> wrong thing to do.
>
> Please fix those entry points into the stack instead by ensuring
> that the IP header is valid.

Understood, thanks.  v3 (posted as a new thread) drops the
xfrm4_transport_output() change and validates the header at the
xfrmi_xmit() entry instead, mirroring the pskb_inet_may_pull() call
that vti_tunnel_xmit() already has:

    <20260923032456.45814-1-q.h.hack.winter@gmail.com>

Thanks,
Qihang

      reply	other threads:[~2026-09-23  3:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  7:22 [PATCH] xfrm: validate ihl in xfrm4_transport_output() Qihang
2026-09-21  7:52 ` netdev-bot+sashiko
2026-09-23  2:16   ` Qihang
2026-09-23  2:16 ` [PATCH net v2] " Qihang
2026-09-23  2:24   ` Herbert Xu
2026-09-23  3:28     ` Qihang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923032840.46294-1-q.h.hack.winter@gmail.com \
    --to=q.h.hack.winter@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.