Re: [PATCH 1/3] s390/mm: Drop all pxdp_get()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mm: s390 build failure due to conflicting types for pxdp_get() helpers
--

commit f8684b75ea3db8facc582e1cba2e98f8430ce2eb
Author: Anshuman Khandual <anshuman.khandual@arm.com>

s390/mm: Drop all pxdp_get()

This commit removes the s390 platform-specific pxdp_get() helpers, relying
instead on the generic definitions in the core MM headers. It also adds
forward declarations for these generic helpers to satisfy local dependencies.

> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
> index e882663a58e77..0a0b0ec42b624 100644
> --- a/arch/s390/include/asm/pgtable.h
> +++ b/arch/s390/include/asm/pgtable.h
> @@ -25,6 +25,11 @@
>  #include <asm/page.h>
>  #include <asm/uv.h>
>  
> +static inline pte_t ptep_get(const pte_t *ptep);
> +static inline pud_t pudp_get(const pud_t *pudp);
> +static inline p4d_t p4dp_get(const p4d_t *p4dp);
> +static inline pgd_t pgdp_get(const pgd_t *pgdp);

[Severity: Low]
Does this cause a build failure on s390 due to conflicting types?

These forward declarations define the parameters as const pointers, but the
generic fallback definitions specify a non-const pointer. For example, in
include/linux/pgtable.h:

static inline pte_t ptep_get(pte_t *ptep)
{
        return READ_ONCE(*ptep);
}

This mismatch between const pte_t * and pte_t * appears to result in a fatal
compile-time error during the build.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923043226.331880-1-anshuman.khandual@arm.com?part=1