From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [linux-next:master 7149/8910] drivers/gpu/drm/display/drm_hdmi_helper.c:656 drm_connector_hdmi_sync_scdc() warn: variable dereferenced before check 'connector' (see line 650)
Date: Wed, 23 Sep 2026 05:50:33 +0200 [thread overview]
Message-ID: <202609230549.j4KCLEad-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
CC: Maxime Ripard <mripard@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: a8c591ed6b672915e0be57843f943a2a723aff40
commit: d653818324edc79d8dd55f77496220d3849910d0 [7149/8910] drm/display: hdmi: Add HDMI 2.0 scrambling management helpers
:::::: branch date: 14 hours ago
:::::: commit date: 3 days ago
config: alpha-randconfig-r2201-20260923 (https://download.01.org/0day-ci/archive/20260923/202609230549.j4KCLEad-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 8.5.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202609230549.j4KCLEad-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/display/drm_hdmi_helper.c:656 drm_connector_hdmi_sync_scdc() warn: variable dereferenced before check 'connector' (see line 650)
vim +/connector +656 drivers/gpu/drm/display/drm_hdmi_helper.c
d653818324edc79 Cristian Ciocaltea 2026-09-01 625
d653818324edc79 Cristian Ciocaltea 2026-09-01 626 /**
d653818324edc79 Cristian Ciocaltea 2026-09-01 627 * drm_connector_hdmi_sync_scdc() - resync the sink-side SCDC upon reconnect
d653818324edc79 Cristian Ciocaltea 2026-09-01 628 * @connector: connector
d653818324edc79 Cristian Ciocaltea 2026-09-01 629 * @plugged: connector plugged status event
d653818324edc79 Cristian Ciocaltea 2026-09-01 630 * @ctx: initialized lock acquisition context
d653818324edc79 Cristian Ciocaltea 2026-09-01 631 *
d653818324edc79 Cristian Ciocaltea 2026-09-01 632 * When receiving hotplug disconnect/reconnect event, while the display is
d653818324edc79 Cristian Ciocaltea 2026-09-01 633 * still active (CRTC enabled), the SCDC status on the sink side is reset
d653818324edc79 Cristian Ciocaltea 2026-09-01 634 * and must be explicitly restored.
d653818324edc79 Cristian Ciocaltea 2026-09-01 635 *
d653818324edc79 Cristian Ciocaltea 2026-09-01 636 * The typical solution for this is to trigger an empty modeset in
d653818324edc79 Cristian Ciocaltea 2026-09-01 637 * drm_connector_helper_funcs.detect_ctx(), which is what this helper does
d653818324edc79 Cristian Ciocaltea 2026-09-01 638 * by triggering a CRTC reset on reconnection.
d653818324edc79 Cristian Ciocaltea 2026-09-01 639 *
d653818324edc79 Cristian Ciocaltea 2026-09-01 640 * When making use of the HDMI connector framework, this is automatically
d653818324edc79 Cristian Ciocaltea 2026-09-01 641 * triggered via drm_atomic_helper_connector_hdmi_hotplug().
d653818324edc79 Cristian Ciocaltea 2026-09-01 642 *
d653818324edc79 Cristian Ciocaltea 2026-09-01 643 * Returns:
d653818324edc79 Cristian Ciocaltea 2026-09-01 644 * Zero on success, an error code otherwise, including -EDEADLK.
d653818324edc79 Cristian Ciocaltea 2026-09-01 645 */
d653818324edc79 Cristian Ciocaltea 2026-09-01 646 int drm_connector_hdmi_sync_scdc(struct drm_connector *connector, bool plugged,
d653818324edc79 Cristian Ciocaltea 2026-09-01 647 struct drm_modeset_acquire_ctx *ctx)
d653818324edc79 Cristian Ciocaltea 2026-09-01 648 {
d653818324edc79 Cristian Ciocaltea 2026-09-01 649 struct drm_connector_hdmi *hdmi = &connector->hdmi;
d653818324edc79 Cristian Ciocaltea 2026-09-01 @650 struct drm_device *dev = connector->dev;
d653818324edc79 Cristian Ciocaltea 2026-09-01 651 struct drm_connector_state *conn_state;
d653818324edc79 Cristian Ciocaltea 2026-09-01 652 struct drm_crtc *crtc;
d653818324edc79 Cristian Ciocaltea 2026-09-01 653 u8 config;
d653818324edc79 Cristian Ciocaltea 2026-09-01 654 int ret;
d653818324edc79 Cristian Ciocaltea 2026-09-01 655
d653818324edc79 Cristian Ciocaltea 2026-09-01 @656 if (!connector || !plugged || !ctx)
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-09-23 3:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202609230549.j4KCLEad-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.