From: sashiko-bot@kernel.org
To: "Primoz Fiser" <primoz.fiser@norik.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
Frank.Li@kernel.org, robh@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] ARM: dts: imx6qdl: phycore-som: Add custom volt/freq table
Date: Wed, 23 Sep 2026 07:45:19 +0000 [thread overview]
Message-ID: <20260923074520.3633C1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923070505.494949-3-primoz.fiser@norik.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: imx6dl: missing fsl,soc-operating-points violates hardware constraint
--
commit a3b6d4e5af39862c78043d8917ba381472b78ee4
Author: Yunus Bas <y.bas@phytec.de>
ARM: dts: imx6qdl: phycore-som: Add custom volt/freq table
The PHYTEC phyCORE-i.MX6QDL SOM-modules are operating with slightly different
voltage and frequency values. Introduce imx6q- and imx6dl-phycore dtsi files
with the modified power tables to achieve stable condition.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-phycore-som.dtsi
> new file mode 100644
> index 0000000000000..de85c084ac8d3
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-phycore-som.dtsi
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2021 PHYTEC Messtechnik GmbH
> + * Author: Yunus Bas <y.bas@phytec.de>
> + */
> +
> +#include "imx6qdl-phytec-phycore-som.dtsi"
> +
> +&cpu0 {
> + operating-points =
> + /* kHz uV */
> + <996000 1275000>,
^^^^^^^^^^^^^^^^
[Severity: High]
This overrides the operating-points to increase VDD_ARM to 1.275V for the
996MHz tier, but lacks a corresponding fsl,soc-operating-points override.
Without it, VDD_SOC will inherit the default 1.175V from imx6dl.dtsi.
The NXP i.MX6 DualLite hardware datasheet specifies that VDD_ARM_IN must not
exceed VDD_SOC_IN by more than 50mV to prevent latch-up and instability.
Does this 100mV gap risk system instability or hardware damage by violating
this constraint? Note that the newly added imx6q-phytec-phycore-som.dtsi
correctly includes the fsl,soc-operating-points property.
> + <792000 1175000>,
> + <396000 1150000>;
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923070505.494949-1-primoz.fiser@norik.com?part=2
next prev parent reply other threads:[~2026-09-23 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 7:05 [PATCH 0/2] ARM: dts: phyCORE-i.MX6 custom OPP table Primoz Fiser
2026-09-23 7:05 ` [PATCH 1/2] ARM: dts: imx6dl: Add a label to cpu1 node Primoz Fiser
2026-09-23 7:05 ` [PATCH 2/2] ARM: dts: imx6qdl: phycore-som: Add custom volt/freq table Primoz Fiser
2026-09-23 7:45 ` sashiko-bot [this message]
2026-09-23 8:36 ` Primoz Fiser
2026-10-01 14:57 ` [PATCH 0/2] ARM: dts: phyCORE-i.MX6 custom OPP table Frank.Li
-- strict thread matches above, loose matches on Subject: below --
2021-12-13 12:42 [PATCH 1/2] ARM: dts: imx6dl: Add a label to cpu1 node Yunus Bas
2021-12-13 12:42 ` [PATCH 2/2] ARM: dts: imx6qdl: phycore-som: Add custom volt/freq table Yunus Bas
2021-12-13 12:42 ` Yunus Bas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923074520.3633C1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.