From: Leon Romanovsky <leon@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: dsahern@kernel.org, jgg@ziepe.ca, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, yanjun.zhu@linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH] RDMA/nldev: Fix ib_device reference leak in nldev_dellink()
Date: Wed, 23 Sep 2026 11:32:56 +0300 [thread overview]
Message-ID: <20260923083256.GM563127@unreal> (raw)
In-Reply-To: <20260916183101.2092246-1-vulab@iscas.ac.cn>
On Wed, Sep 16, 2026 at 06:31:01PM +0000, Wentao Liang wrote:
> nldev_dellink() takes a reference on the ib_device with
> ib_device_get_by_index(). When the driver's dellink callback fails,
> the function returns the error directly without dropping that
> reference, leaking it. Call ib_device_put() on the dellink error
> path before returning, matching the handling of the other error
> exits in this function.
>
> Fixes: a60e3f3d6fba ("RDMA/nldev: Add dellink function pointer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/infiniband/core/nldev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
It was already fixed, https://patch.msgid.link/20260903082550.2257-1-lirongqing@baidu.com
Thanks
prev parent reply other threads:[~2026-09-23 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 18:31 [PATCH] RDMA/nldev: Fix ib_device reference leak in nldev_dellink() Wentao Liang
2026-09-16 18:38 ` sashiko-bot
2026-09-23 8:32 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923083256.GM563127@unreal \
--to=leon@kernel.org \
--cc=dsahern@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.