diff for duplicates of <202609230952.6jFrseQb-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 3d5b03d..3e9c68a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Jim Cromie <jim.cromie@gmail.com> -TO: "Łukasz Bartosik" <ukaszb@chromium.org> - tree: https://github.com/jimc/linux.git m10 head: f95e4f1e4ce035c9b5f8da68c66d83f2452d92d5 commit: feb8ec0044ac67921562346a4a6b831204667ea9 [35/44] dyndbg: resolve "protection" of class'd pr_debug -:::::: branch date: 4 days ago -:::::: commit date: 4 days ago config: x86_64-randconfig-2200-20260923 (https://download.01.org/0day-ci/archive/20260923/202609230952.6jFrseQb-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb @@ -23,19 +16,6 @@ lib/dynamic_debug.c:854 param_set_dyndbg_module_classes() error: we previously a vim +/map +854 lib/dynamic_debug.c -d88925c4b39c80 Jim Cromie 2025-11-18 819 -d88925c4b39c80 Jim Cromie 2025-11-18 820 /** -d88925c4b39c80 Jim Cromie 2025-11-18 821 * param_set_dyndbg_classes - class FOO >control -d88925c4b39c80 Jim Cromie 2025-11-18 822 * @instr: string echo>d to sysfs, input depends on map_type -d88925c4b39c80 Jim Cromie 2025-11-18 823 * @kp: kp->arg has state: bits/lvl, map, map_type -d88925c4b39c80 Jim Cromie 2025-11-18 824 * @mod_name: module name or null for all modules with the classes -d88925c4b39c80 Jim Cromie 2025-11-18 825 * -d88925c4b39c80 Jim Cromie 2025-11-18 826 * Enable/disable prdbgs by their class, as given in the arguments to -d88925c4b39c80 Jim Cromie 2025-11-18 827 * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative -d88925c4b39c80 Jim Cromie 2025-11-18 828 * levels by bitpos. -d88925c4b39c80 Jim Cromie 2025-11-18 829 * -d88925c4b39c80 Jim Cromie 2025-11-18 830 * Returns: 0 or <0 if error. -b9400852c0801a Jim Cromie 2022-09-04 831 */ 7f10c4fc568572 Jim Cromie 2025-11-18 832 static int param_set_dyndbg_module_classes(const char *instr, 7f10c4fc568572 Jim Cromie 2025-11-18 833 const struct kernel_param *kp, 7f10c4fc568572 Jim Cromie 2025-11-18 834 const char *mod_name) @@ -46,6 +26,9 @@ feb8ec0044ac67 Jim Cromie 2025-11-18 837 struct ddebug_class_map *map = dcp-> b9400852c0801a Jim Cromie 2022-09-04 839 int rc, totct = 0; b9400852c0801a Jim Cromie 2022-09-04 840 feb8ec0044ac67 Jim Cromie 2025-11-18 @841 if (map && !map->controlling_param) + ^^^ +Can map really be NULL? + feb8ec0044ac67 Jim Cromie 2025-11-18 842 map->controlling_param = dcp; feb8ec0044ac67 Jim Cromie 2025-11-18 843 62b32b2a95ef1c Jim Cromie 2025-11-18 844 rc = kstrtou32(instr, 0, &inrep); @@ -59,34 +42,14 @@ b9400852c0801a Jim Cromie 2022-09-04 851 } d88925c4b39c80 Jim Cromie 2025-11-18 852 ddebug_class_param_clamp_input(&inrep, kp); b9400852c0801a Jim Cromie 2022-09-04 853 b9400852c0801a Jim Cromie 2022-09-04 @854 switch (map->map_type) { + ^^^^^ +Because if so we are in trouble. + b9400852c0801a Jim Cromie 2022-09-04 855 case DD_CLASS_TYPE_DISJOINT_BITS: 7f10c4fc568572 Jim Cromie 2025-11-18 856 old_val = READ_ONCE(*dcp->bits); 62b32b2a95ef1c Jim Cromie 2025-11-18 857 v2pr_info("bits:0x%x > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); a62837264de615 Jim Cromie 2025-11-18 858 totct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name); 7f10c4fc568572 Jim Cromie 2025-11-18 859 WRITE_ONCE(*dcp->bits, inrep); -b9400852c0801a Jim Cromie 2022-09-04 860 break; -b9400852c0801a Jim Cromie 2022-09-04 861 case DD_CLASS_TYPE_LEVEL_NUM: -7f10c4fc568572 Jim Cromie 2025-11-18 862 old_val = READ_ONCE(*dcp->lvl); -7f10c4fc568572 Jim Cromie 2025-11-18 863 old_bits = CLASSMAP_BITMASK(old_val); -b9400852c0801a Jim Cromie 2022-09-04 864 new_bits = CLASSMAP_BITMASK(inrep); -62b32b2a95ef1c Jim Cromie 2025-11-18 865 v2pr_info("lvl:%u bits:0x%x > %s\n", inrep, new_bits, KP_NAME(kp)); -a62837264de615 Jim Cromie 2025-11-18 866 totct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); -7f10c4fc568572 Jim Cromie 2025-11-18 867 WRITE_ONCE(*dcp->lvl, inrep); -b9400852c0801a Jim Cromie 2022-09-04 868 break; -b9400852c0801a Jim Cromie 2022-09-04 869 default: -b9400852c0801a Jim Cromie 2022-09-04 870 pr_warn("%s: bad map type: %d\n", KP_NAME(kp), map->map_type); -cec8bafd130370 Jim Cromie 2025-11-18 871 return -EINVAL; -b9400852c0801a Jim Cromie 2022-09-04 872 } -b9400852c0801a Jim Cromie 2022-09-04 873 vpr_info("%s: total matches: %d\n", KP_NAME(kp), totct); -b9400852c0801a Jim Cromie 2022-09-04 874 return 0; -b9400852c0801a Jim Cromie 2022-09-04 875 } -7f10c4fc568572 Jim Cromie 2025-11-18 876 - -:::::: The code at line 854 was first introduced by commit -:::::: b9400852c0801aebee4fc8b62e6b7cc69c7fcbda dyndbg: add drm.debug style (drm/parameters/debug) bitmap support - -:::::: TO: Jim Cromie <jim.cromie@gmail.com> -:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 417b12b..ea185ad 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,16 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[jimc:m10 35/44] lib/dynamic_debug.c:854 param_set_dyndbg_module_classes() error: we previously assumed 'map' could be null (see line 841)\0" - "Date\0Wed, 23 Sep 2026 09:28:39 +0200\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 23 Sep 2026 11:37:30 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + Jim Cromie <jim.cromie@gmail.com> + " \305\201ukasz Bartosik <ukaszb@chromium.org>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Jim Cromie <jim.cromie@gmail.com>\n" - "TO: \"\305\201ukasz Bartosik\" <ukaszb@chromium.org>\n" - "\n" "tree: https://github.com/jimc/linux.git m10\n" "head: f95e4f1e4ce035c9b5f8da68c66d83f2452d92d5\n" "commit: feb8ec0044ac67921562346a4a6b831204667ea9 [35/44] dyndbg: resolve \"protection\" of class'd pr_debug\n" - ":::::: branch date: 4 days ago\n" - ":::::: commit date: 4 days ago\n" "config: x86_64-randconfig-2200-20260923 (https://download.01.org/0day-ci/archive/20260923/202609230952.6jFrseQb-lkp@intel.com/config)\n" "compiler: gcc-14 (Debian 14.2.0-19) 14.2.0\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -31,19 +26,6 @@ "\n" "vim +/map +854 lib/dynamic_debug.c\n" "\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 819 \n" - "d88925c4b39c80 Jim Cromie 2025-11-18 820 /**\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 821 * param_set_dyndbg_classes - class FOO >control\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 822 * @instr: string echo>d to sysfs, input depends on map_type\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 823 * @kp: kp->arg has state: bits/lvl, map, map_type\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 824 * @mod_name: module name or null for all modules with the classes\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 825 *\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 826 * Enable/disable prdbgs by their class, as given in the arguments to\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 827 * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 828 * levels by bitpos.\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 829 *\n" - "d88925c4b39c80 Jim Cromie 2025-11-18 830 * Returns: 0 or <0 if error.\n" - "b9400852c0801a Jim Cromie 2022-09-04 831 */\n" "7f10c4fc568572 Jim Cromie 2025-11-18 832 static int param_set_dyndbg_module_classes(const char *instr,\n" "7f10c4fc568572 Jim Cromie 2025-11-18 833 \t\t\t\t\t const struct kernel_param *kp,\n" "7f10c4fc568572 Jim Cromie 2025-11-18 834 \t\t\t\t\t const char *mod_name)\n" @@ -54,6 +36,9 @@ "b9400852c0801a Jim Cromie 2022-09-04 839 \tint rc, totct = 0;\n" "b9400852c0801a Jim Cromie 2022-09-04 840 \n" "feb8ec0044ac67 Jim Cromie 2025-11-18 @841 \tif (map && !map->controlling_param)\n" + " ^^^\n" + "Can map really be NULL?\n" + "\n" "feb8ec0044ac67 Jim Cromie 2025-11-18 842 \t\tmap->controlling_param = dcp;\n" "feb8ec0044ac67 Jim Cromie 2025-11-18 843 \n" "62b32b2a95ef1c Jim Cromie 2025-11-18 844 \trc = kstrtou32(instr, 0, &inrep);\n" @@ -67,37 +52,17 @@ "d88925c4b39c80 Jim Cromie 2025-11-18 852 \tddebug_class_param_clamp_input(&inrep, kp);\n" "b9400852c0801a Jim Cromie 2022-09-04 853 \n" "b9400852c0801a Jim Cromie 2022-09-04 @854 \tswitch (map->map_type) {\n" + " ^^^^^\n" + "Because if so we are in trouble.\n" + "\n" "b9400852c0801a Jim Cromie 2022-09-04 855 \tcase DD_CLASS_TYPE_DISJOINT_BITS:\n" "7f10c4fc568572 Jim Cromie 2025-11-18 856 \t\told_val = READ_ONCE(*dcp->bits);\n" "62b32b2a95ef1c Jim Cromie 2025-11-18 857 \t\tv2pr_info(\"bits:0x%x > %s.%s\\n\", inrep, mod_name ?: \"*\", KP_NAME(kp));\n" "a62837264de615 Jim Cromie 2025-11-18 858 \t\ttotct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name);\n" "7f10c4fc568572 Jim Cromie 2025-11-18 859 \t\tWRITE_ONCE(*dcp->bits, inrep);\n" - "b9400852c0801a Jim Cromie 2022-09-04 860 \t\tbreak;\n" - "b9400852c0801a Jim Cromie 2022-09-04 861 \tcase DD_CLASS_TYPE_LEVEL_NUM:\n" - "7f10c4fc568572 Jim Cromie 2025-11-18 862 \t\told_val = READ_ONCE(*dcp->lvl);\n" - "7f10c4fc568572 Jim Cromie 2025-11-18 863 \t\told_bits = CLASSMAP_BITMASK(old_val);\n" - "b9400852c0801a Jim Cromie 2022-09-04 864 \t\tnew_bits = CLASSMAP_BITMASK(inrep);\n" - "62b32b2a95ef1c Jim Cromie 2025-11-18 865 \t\tv2pr_info(\"lvl:%u bits:0x%x > %s\\n\", inrep, new_bits, KP_NAME(kp));\n" - "a62837264de615 Jim Cromie 2025-11-18 866 \t\ttotct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name);\n" - "7f10c4fc568572 Jim Cromie 2025-11-18 867 \t\tWRITE_ONCE(*dcp->lvl, inrep);\n" - "b9400852c0801a Jim Cromie 2022-09-04 868 \t\tbreak;\n" - "b9400852c0801a Jim Cromie 2022-09-04 869 \tdefault:\n" - "b9400852c0801a Jim Cromie 2022-09-04 870 \t\tpr_warn(\"%s: bad map type: %d\\n\", KP_NAME(kp), map->map_type);\n" - "cec8bafd130370 Jim Cromie 2025-11-18 871 \t\treturn -EINVAL;\n" - "b9400852c0801a Jim Cromie 2022-09-04 872 \t}\n" - "b9400852c0801a Jim Cromie 2022-09-04 873 \tvpr_info(\"%s: total matches: %d\\n\", KP_NAME(kp), totct);\n" - "b9400852c0801a Jim Cromie 2022-09-04 874 \treturn 0;\n" - "b9400852c0801a Jim Cromie 2022-09-04 875 }\n" - "7f10c4fc568572 Jim Cromie 2025-11-18 876 \n" - "\n" - ":::::: The code at line 854 was first introduced by commit\n" - ":::::: b9400852c0801aebee4fc8b62e6b7cc69c7fcbda dyndbg: add drm.debug style (drm/parameters/debug) bitmap support\n" - "\n" - ":::::: TO: Jim Cromie <jim.cromie@gmail.com>\n" - ":::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -b5fd6d9f4826c94e198caa7919b0fd600cf446359300e1572e0d5e62ba77b08a +b54dd348d50a1708423f6bb123fb019d24b508b538673ecb8d7141c80e83cb34
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.