From: sashiko-bot@kernel.org
To: "Primoz Fiser" <primoz.fiser@norik.com>
Cc: mfd@lists.linux.dev, linux-watchdog@vger.kernel.org,
imx@lists.linux.dev, devicetree@vger.kernel.org,
conor+dt@kernel.org, lee@kernel.org, robh@kernel.org,
Frank.Li@kernel.org
Subject: Re: [PATCH 2/4] mfd: da9061: make register CONFIG_I writable
Date: Wed, 23 Sep 2026 11:23:24 +0000 [thread overview]
Message-ID: <20260923112324.8A4031F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923111719.2032012-3-primoz.fiser@norik.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: commit message description is not capitalized
--
commit 5997b5e9bac966d2caba888fc1dfee5d188e81e0
Author: Andrej Picej <andrej.picej@norik.com>
mfd: da9061: make register CONFIG_I writable
This commit makes the configuration register CONFIG_I writable to allow
changing the watchdog mode.
> mfd: da9061: make register CONFIG_I writable
[Severity: Low]
This isn't a bug, but the MFD subsystem guidelines explicitly require the
description after the subsystem prefix to be capitalized. Should the commit
message title be updated to "mfd: da9061: Make register CONFIG_I writable"
to ensure it follows the standard Git history categorization for this
subsystem?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923111719.2032012-1-primoz.fiser@norik.com?part=2
next prev parent reply other threads:[~2026-09-23 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 11:17 [PATCH 0/4] da9062/da9061 watchdog timeout mode Primoz Fiser
2026-09-23 11:17 ` [PATCH 1/4] mfd: da9062: make register CONFIG_I writable Primoz Fiser
2026-09-23 11:25 ` sashiko-bot
2026-09-23 11:17 ` [PATCH 2/4] mfd: da9061: " Primoz Fiser
2026-09-23 11:23 ` sashiko-bot [this message]
2026-09-23 11:17 ` [PATCH 3/4] watchdog: da9062: reset board on watchdog timeout Primoz Fiser
2026-09-23 11:25 ` sashiko-bot
2026-09-23 21:01 ` Guenter Roeck
2026-09-23 21:03 ` Guenter Roeck
2026-09-23 11:17 ` [PATCH 4/4] ARM: dts: imx6: phycore-som: set watchdog timeout mode to shutdown Primoz Fiser
2026-09-23 11:23 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923112324.8A4031F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=lee@kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=primoz.fiser@norik.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.