Re: [PATCH v3 1/2] arm64: dts: allwinner: h616: orangepi-zero2w: add 24-pin expansion overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing USB 2.0 nodes in 24-pin expansion board overlay
--

commit 1a9550663d27bb916af61d191100635d3dbfb863
Author: Vladimir <anykey196@gmail.com>

arm64: dts: allwinner: h616: orangepi-zero2w: add 24-pin expansion overlay

This adds a devicetree overlay for the optional 24-pin expansion board, which
provides two buttons on LRADC channel 0 and an IR receiver.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w-24pin.dtso b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w-24pin.dtso
> new file mode 100644
> index 0000000000000..2d7e98e4b66d8
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero2w-24pin.dtso

[ ... ]

> +&lradc {
> +	vref-supply = <&reg_vcc3v3>;
> +	status = "okay";
> +	wakeup-source;
> +
> +	button-1000 {
> +		label = "KEY_1";
> +		linux,code = <KEY_1>;
> +		channel = <0>;
> +		voltage = <1000000>;
> +	};
> +
> +	button-1600 {
> +		label = "KEY_ENTER";
> +		linux,code = <KEY_ENTER>;
> +		channel = <0>;
> +		voltage = <1600000>;
> +	};
> +};
> +
> +&ir {
> +	status = "okay";
> +};

[Severity: Medium]
Are the USB 2.0 nodes missing here?

The base board device tree (sun50i-h618-orangepi-zero2w.dts) explicitly leaves
USB 2 and 3 disabled, expecting them to be enabled by an overlay. Without
references to &ehci2, &ehci3, &ohci2, and &ohci3, the physical USB ports on the
24-pin expansion board will remain disabled and non-functional when this
overlay is applied.

Could these nodes be added so the expansion board is fully supported?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923112009.1062-1-anykey196@gmail.com?part=1