From: Stephen Hemminger <stephen@networkplumber.org>
To: <ykanaujia@marvell.com>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
Harman Kalra <hkalra@marvell.com>, <dev@dpdk.org>
Subject: Re: [PATCH 2/2] drivers: add support for async RTE FLOW APIs
Date: Wed, 23 Sep 2026 11:39:10 -0700 [thread overview]
Message-ID: <20260923113910.7c6bb91c@phoenix.local> (raw)
In-Reply-To: <20260715084545.301064-1-ykanaujia@marvell.com>
On Wed, 15 Jul 2026 14:15:20 +0530
<ykanaujia@marvell.com> wrote:
> From: Yashaswini Kanaujia <ykanaujia@marvell.com>
>
> added support for asynchronous rte_flow APIs
> for cn10k device
>
> Signed-off-by: Yashaswini Kanaujia <ykanaujia@marvell.com>
> ---
AI review found issues with the patch.
f58b114027 "net/cnxk: support async flow API" — the code is genuinely
well-written; I found no memory-safety defects. Bounds on nb_items/nb_actions are
enforced at template creation with comments naming the fixed-size stack arrays
they protect, template indices and queue_id are checked at every entry point,
refcounts prevent destroy-while-in-use, and create_by_index is a deliberate
ENOTSUP stub rather than an unfinished path.
The problems are process ones: the message says "for cn10k device" but the patch
also wires up cn20k; ~3200 lines as a single commit with a 2-line message; no
release notes and no cnxk.ini feature-flag update for a new user-visible feature;
and a stray blank line removed at cn20k_ethdev.c:8.
prev parent reply other threads:[~2026-09-23 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 8:45 [PATCH 2/2] drivers: add support for async RTE FLOW APIs ykanaujia
2026-09-14 6:53 ` Jerin Jacob
2026-09-23 18:39 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923113910.7c6bb91c@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=ykanaujia@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.