Re: [PATCH bpf-next 2/2] selftests/bpf: Enable gotox tests for riscv64

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bpf: multi-line comment style violation in verifier_gotox.c
--

commit 265e53ef1a0972464a42276e591e566a09035885
Author: Chen Pei <cp0613@linux.alibaba.com>

selftests/bpf: Enable gotox tests for riscv64
    
This commit enables gotox tests for the riscv64 JIT since it now supports
the gotox instruction and jump tables. It modifies verifier_gotox.c to
include riscv64 in the supported architectures macro.

> diff --git a/tools/testing/selftests/bpf/progs/verifier_gotox.c b/tools/testing/selftests/bpf/progs/verifier_gotox.c
> index 5b18c9a27717b..4a38f7da720af 100644
> --- a/tools/testing/selftests/bpf/progs/verifier_gotox.c
> +++ b/tools/testing/selftests/bpf/progs/verifier_gotox.c

[ ... ]

> @@ -409,6 +411,8 @@ __naked void spill_fill_ptr_to_insn(void)
>  	: __clobber_all);
>  }
>  
> -#endif /* __TARGET_ARCH_x86 || __TARGET_ARCH_arm64 || __TARGET_ARCH_powerpc*/
> +#endif /* __TARGET_ARCH_x86 || __TARGET_ARCH_arm64 ||
> +	* __TARGET_ARCH_powerpc || __TARGET_ARCH_riscv
> +	*/

[Severity: Low]
This isn't a bug, but does this newly introduced multi-line comment follow
the BPF subsystem style guide? The subsystem guidelines explicitly require
that multi-line comments have the opening '/*' on its own line, rather than
beginning text on the same line as the opening marker.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923130856.1157-1-cp0613@linux.alibaba.com?part=2