All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@kernel.org>
To: linux-m68k@lists.linux-m68k.org
Cc: Greg Ungerer <gerg@linux-m68k.org>
Subject: [PATCH] m68knommu: fix compile breakage for 5407 cleopatra board
Date: Thu, 24 Sep 2026 00:35:38 +1000	[thread overview]
Message-ID: <20260923143538.2076420-1-gerg@kernel.org> (raw)

From: Greg Ungerer <gerg@linux-m68k.org>

Compiling for the Cleopatra target and specifying the ColdFire 5407 SoC
will fail with the following errors:

  m68k-linux-ld: arch/m68k/coldfire/nettel.o: in function `init_nettel':
  nettel.c:(.init.text+0x74): undefined reference to `ppdata'
  m68k-linux-ld: nettel.c:(.init.text+0x9c): undefined reference to `ppdata'
  m68k-linux-ld: nettel.c:(.init.text+0x6a): undefined reference to `ppdata'
  m68k-linux-ld: nettel.c:(.init.text+0x7a): undefined reference to `ppdata'
  m68k-linux-ld: nettel.c:(.init.text+0x92): undefined reference to `ppdata'

The fix is to define "ppdata" in the same way as is done for the 5307 and
5272 - it is the same register setup in the 5407 as those other SoC parts.

Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
---
 arch/m68k/coldfire/m5407.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/m68k/coldfire/m5407.c b/arch/m68k/coldfire/m5407.c
index 23a14416241c..1f3e30b33398 100644
--- a/arch/m68k/coldfire/m5407.c
+++ b/arch/m68k/coldfire/m5407.c
@@ -22,6 +22,11 @@
 
 /***************************************************************************/
 
+/*
+ *	Some platforms need software versions of the GPIO data registers.
+ */
+unsigned short ppdata;
+
 DEFINE_CLK(pll, "pll.0", MCF_CLK);
 DEFINE_CLK(sys, "sys.0", MCF_BUSCLK);
 
-- 
2.55.0


                 reply	other threads:[~2026-09-23 14:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923143538.2076420-1-gerg@kernel.org \
    --to=gerg@kernel.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.