From: sashiko-bot@kernel.org
To: "Petko Manolov" <petko.manolov@konsulko.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
Date: Wed, 23 Sep 2026 14:55:59 +0000 [thread overview]
Message-ID: <20260923145600.072441F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923144905.3365851-2-petko.manolov@konsulko.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing 'draeger' vendor prefix in vendor-prefixes.yaml
--
commit cb9d16ad6756673a5b26300c6dbed7353bb41b62
Author: Petko Manolov <petko.manolov@konsulko.com>
dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
This adds device tree binding compatible strings for the Draeger M48
heterogeneous board. The bindings support both the i.MX6Q and i.MX6DL
variants used in the hardware.
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 86876311ec59a..2abcae70f33b8 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -260,6 +260,7 @@ properties:
> - boundary,imx6q-nitrogen6x
> - compulab,cm-fx6 # CompuLab CM-FX6
> - dmo,imx6q-edmqmx6 # Data Modul eDM-QMX6 Board
> + - draeger,imx6q-m48 # Draeger imx6q variant of M48
[Severity: Low]
Is the "draeger" vendor prefix documented in vendor-prefixes.yaml?
The dt-bindings subsystem requires every newly introduced vendor prefix to
be formally documented. Failing to add it can cause make dt_binding_check
to fail with a schema validation error for an unrecognized vendor prefix.
> - ds,imx6q-sbc # Da Sheng COM-9XX Modules
> - embest,imx6q-marsboard # Embest MarS Board i.MX6Dual
> - emtrion,emcon-mx6 # emCON-MX6D or emCON-MX6Q SoM
[ ... ]
> @@ -458,6 +459,7 @@ properties:
> - boundary,imx6dl-nit6xlite # Boundary Devices Nitrogen6 Lite
> - boundary,imx6dl-nitrogen6x # Boundary Devices Nitrogen6x
> - bticino,imx6dl-mamoj # BTicino i.MX6DL Mamoj
> + - draeger,imx6dl-m48 # Draeger imx6dl variant of M48
[Severity: Low]
Will this also trigger a validation error during make dt_binding_check?
Similar to the previous addition, this introduces the undocumented "draeger"
prefix for the i.MX6DL variant, which leaves the binding implementation
incomplete.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923144905.3365851-1-petko.manolov@konsulko.com?part=1
next prev parent reply other threads:[~2026-09-23 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 14:49 [PATCH v1 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-09-23 14:49 ` [PATCH v1 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-09-23 14:55 ` sashiko-bot [this message]
2026-09-23 16:32 ` Conor Dooley
2026-09-23 14:49 ` [PATCH v1 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
2026-09-23 15:04 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923145600.072441F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=petko.manolov@konsulko.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.