All of lore.kernel.org
 help / color / mirror / Atom feed
From: abkarada <abdurrahmankaradag19@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: pkshih@realtek.com, kvalo@kernel.org, briannorris@chromium.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH rtw-next] wifi: rtw88: pci: recover from a stalled TX ring
Date: Wed, 23 Sep 2026 18:04:03 +0300	[thread overview]
Message-ID: <20260923150403.184831-1-abdurrahmankaradag19@gmail.com> (raw)
In-Reply-To: <6f2a314798c64ccfbfd59ac8a8ee6e01@realtek.com>

Sorry for the slow reply. I wanted to answer your questions with
measurements rather than with an opinion, and that took a while.

> > +               stopped = ring->queue_stopped;
> > +               ring->last_rp = cur_rp;
>
> Does software pointer cause driver doesn't restart queue?
> Or without changes of this chunk, the stuck can be resolved?

No. last_rp and stall_cnt are detection state only; they never touch the
data path. The only action in the patch is the kick below.

> I mean just doing this kick is enough to resolve the stuck?

No, and you were right to ask twice.

I taught my watchdog to rewrite the TXBD host index during a real stall
and then measure whether the hardware read index moves. Three live
occurrences since:

  2026-09-06 03:17   BE rp 0x00b7 before and after the rewrite
  2026-09-14 17:48   BE rp 0x00c9 before and after (wp 0x6c -> 0x6d)
  2026-09-14 19:09   BE rp 0x009e before and after (wp 0x50 -> 0x51)

In all three the read index never moved and traffic stayed at 100% loss.
The premise of this patch is wrong: the hardware is not waiting to be
told about new descriptors, it has stopped consuming them, and writing
the doorbell again changes nothing.

Please drop this patch. I will not resend it in this form.

I have sent a longer reply in the bug thread with the rest of the data,
including the fact that the stall also happens on 7.0.12, so my earlier
good/bad version claim was wrong as well. It also proposes a different
direction for the driver side, which I would rather agree with you
before writing.

Thanks for the review, and for pushing back on the mechanism.

      reply	other threads:[~2026-09-23 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  9:17 [PATCH rtw-next] wifi: rtw88: pci: recover from a stalled TX ring Abdurrahman Karadag
2026-09-06  4:16 ` Ping-Ke Shih
2026-09-23 15:04   ` abkarada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923150403.184831-1-abdurrahmankaradag19@gmail.com \
    --to=abdurrahmankaradag19@gmail.com \
    --cc=briannorris@chromium.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.