Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add Samsung S5K3T2 image sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing physical hardware requirements in required list
--

commit 430d5cdb46dd5406d0df9a1e8177756edd38bbfb
Author: Armandas Kvietkus <armandas.kvietkus@proton.me>

dt-bindings: media: i2c: Add Samsung S5K3T2 image sensor

This commit introduces the device tree binding for the Samsung S5K3T2 20
Mpixel CMOS image sensor. It defines properties for clocks, supplies, resets,
and the MIPI D-PHY port interface.

> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k3t2.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3t2.yaml
> new file mode 100644
> index 0000000000000..83b3d55a8ea76
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3t2.yaml

[ ... ]

> +        required:
> +          - link-frequencies
> +
> +required:
> +  - compatible
> +  - reg
> +  - port

[Severity: Low]
Should clocks, vdda-supply, vddd-supply, and vddio-supply be included in this
required list to enforce a complete hardware description?

If a device tree author defines a samsung,s5k3t2 node but omits the clocks or
power supply properties, the incomplete hardware configuration will silently
pass schema validation.

> +
> +unevaluatedProperties: false
> +
> +examples:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-upstream-s5k3t2-v2-0-04ffda3350c1@proton.me?part=1