From: sashiko-bot@kernel.org
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Marc Zyngier" <maz@kernel.org>,
kvmarm@lists.linux.dev,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Oliver Upton" <oupton@kernel.org>
Subject: Re: [PATCH v4 03/14] KVM: arm64: Use ESR helpers in guest abort handling
Date: Wed, 23 Sep 2026 15:24:07 +0000 [thread overview]
Message-ID: <20260923152408.0DFCC1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923-kvm-arm-prefault-v4-3-d4b0b4dfa8c3@kernel.org>
> Convert kvm_vcpu_* ESR wrappers in kvm_emulate.h and the stage-2 abort
> handling logic in mmu.c to use the newly introduced ESR helpers.
>
> kvm_is_write_fault() is split in two, with esr_abt_is_write_fault()
> handling the esr parts of the operation and kvm_is_write_fault() wrapping
> it.
>
> Introduce/modify kvm_s2_fault_is_{perm,exec,write}(),
> kvm_s2_perm_fault_granule() so the abort path reads the ESR from a single
> place.
>
> This is to allow a later change to permit stage 2 pre-faulting via a
> synthetic ESR value.
>
> Remove now-unused kvm_vcpu_dabt_is_cm(), kvm_vcpu_trap_is_exec_fault() and
> kvm_vcpu_trap_get_perm_fault_granule().
>
> No functional change intended.
>
> Reviewed-by: Oliver Upton <oupton@kernel.org>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-kvm-arm-prefault-v4-0-d4b0b4dfa8c3@kernel.org?part=3
next prev parent reply other threads:[~2026-09-23 15:24 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 15:15 [PATCH v4 00/14] KVM: arm64: Add KVM_PRE_FAULT_MEMORY support Lorenzo Stoakes (ARM)
2026-09-23 15:15 ` [PATCH v4 01/14] KVM: Allow architectures to disallow pre-fault Lorenzo Stoakes (ARM)
2026-09-23 15:24 ` sashiko-bot
2026-09-23 17:29 ` Sean Christopherson
2026-09-23 18:52 ` Fuad Tabba
2026-09-24 8:22 ` Lorenzo Stoakes (ARM)
2026-09-24 22:29 ` Marc Zyngier
2026-09-23 15:15 ` [PATCH v4 02/14] arm64: Add ESR fault helpers Lorenzo Stoakes (ARM)
2026-09-23 15:25 ` sashiko-bot
2026-09-23 18:24 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 03/14] KVM: arm64: Use ESR helpers in guest abort handling Lorenzo Stoakes (ARM)
2026-09-23 15:24 ` sashiko-bot [this message]
2026-09-23 18:23 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 04/14] KVM: arm64: Propagate and use esr in s2fd when handling guest aborts Lorenzo Stoakes (ARM)
2026-09-23 15:24 ` sashiko-bot
2026-09-23 18:24 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 05/14] KVM: arm64: Propagate and use mmu " Lorenzo Stoakes (ARM)
2026-09-23 15:29 ` sashiko-bot
2026-09-23 18:24 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 06/14] KVM: arm64: Propagate and use kvm_s2_fault_result on S2 fault Lorenzo Stoakes (ARM)
2026-09-23 15:27 ` sashiko-bot
2026-09-23 18:25 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 07/14] KVM: arm64: Size the stage-2 memcache from the fault MMU Lorenzo Stoakes (ARM)
2026-09-23 15:25 ` sashiko-bot
2026-09-23 15:15 ` [PATCH v4 08/14] KVM: arm64: Propagate EHWPOISON in kvm_s2_fault_pin_pfn() Lorenzo Stoakes (ARM)
2026-09-23 15:23 ` sashiko-bot
2026-09-23 15:15 ` [PATCH v4 09/14] KVM: arm64: Pass walk flags to kvm_pgtable_get_leaf() Lorenzo Stoakes (ARM)
2026-09-23 15:21 ` sashiko-bot
2026-09-23 15:15 ` [PATCH v4 10/14] KVM: arm64: Implement KVM_PRE_FAULT_MEMORY Lorenzo Stoakes (ARM)
2026-09-23 15:33 ` sashiko-bot
2026-09-23 15:15 ` [PATCH v4 11/14] Documentation: KVM: document arm64 KVM_PRE_FAULT_MEMORY Lorenzo Stoakes (ARM)
2026-09-23 15:31 ` sashiko-bot
2026-09-24 6:08 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 12/14] KVM: selftests: Enable pre_fault_memory_test for arm64 Lorenzo Stoakes (ARM)
2026-09-23 15:29 ` sashiko-bot
2026-09-24 6:08 ` Fuad Tabba
2026-09-23 15:15 ` [PATCH v4 13/14] KVM: selftests: Add option for different backing in pre-fault tests Lorenzo Stoakes (ARM)
2026-09-23 15:30 ` sashiko-bot
2026-09-24 6:08 ` Fuad Tabba
2026-09-24 8:28 ` Lorenzo Stoakes (ARM)
2026-09-23 15:15 ` [PATCH v4 14/14] KVM: selftests: Add nested pre-fault test for arm64 Lorenzo Stoakes (ARM)
2026-09-23 15:29 ` sashiko-bot
2026-09-24 6:09 ` [PATCH v4 00/14] KVM: arm64: Add KVM_PRE_FAULT_MEMORY support Fuad Tabba
2026-09-24 21:08 ` Marc Zyngier
2026-09-25 8:51 ` Lorenzo Stoakes (ARM)
2026-09-25 19:48 ` Marc Zyngier
2026-09-24 22:36 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923152408.0DFCC1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-s390@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.