Re: [PATCH] RDMA/mlx5: Restore flow_attr-first layout in leftovers flow rules

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, Sep 23, 2026 at 03:45:47PM +0300, Leon Romanovsky wrote:
> On Wed, Sep 23, 2026 at 08:41:48AM -0400, Leon Romanovsky wrote:
> > 
> > On Thu, 17 Sep 2026 19:17:22 +0800, lirongqing wrote:
> > > Commit e91fb8b9d0ed ("RDMA/mlx5: Avoid flexible array warning") split
> > > the leftovers_specs[] array into two separate structs to silence the
> > > "array of flexible structures" sparse warning, but in doing so
> > > reversed the member order: eth_flow was placed before flow_attr.
> > > 
> > > _create_flow_rule() locates the flow specs with:
> > > 
> > > [...]
> > 
> > Applied, thanks!
> 
> I dropped it, as it causes to flex array errors to return.

Yeah, but the bug is real..

There is a macro for this case:

	static TRAILING_OVERLAP(struct ib_flow_attr, flow_attr, flows,
		struct ib_flow_spec_eth eth_flow;
	) leftovers_wc = { .flow_attr = { .num_of_specs = 1,

Jason