Re: [PATCH v11 10/20] drm/xe/vsec: Support possible hotplug exit

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] cleanup: mixing goto and scope-based cleanup in xe_pmt_telem_read
--

commit 56101e5a8aff0e2c0ff7ea54aedbab708db223de
Author: Michael J. Ruhl <michael.j.ruhl@intel.com>

drm/xe/vsec: Support possible hotplug exit

DRM has an API that will verify that a device is valid in the hotplug
context.

Verify device is valid before access in the VSEC callback API.

> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index 082b25b017db6..c0e06b2aeca66 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
[ ... ]
> @@ -188,11 +199,14 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
>  		xe_pm_runtime_get(xe);
>  		break;
>  	case TELEMETRY:
> -		if (!xe_pm_runtime_get_if_active(xe))
> -			return -ENODATA;
> +		if (!xe_pm_runtime_get_if_active(xe)) {
> +			ret = -ENODATA;
> +			goto dev_exit;
> +		}
>  		break;
>  	case WATCHER:
> -		return -EINVAL;
> +		ret = -EINVAL;
> +		goto dev_exit;
>  	}
>  
>  	scoped_guard(mutex, &xe->pmt.lock) {

[Severity: Low]
Does this code violate the kernel cleanup API guidelines by mixing goto-based
error handling with scope-based cleanup in the same function?

The patch introduces goto statements to a dev_exit label in xe_pmt_telem_read
in drivers/gpu/drm/xe/xe_vsec.c, a function which already uses scoped_guard.
According to include/linux/cleanup.h, mixing goto and cleanup helpers in the
same function is discouraged because it can create confusing ownership
semantics and risk double-free or leak bugs.

Could a scope-based cleanup helper be created for the drm_dev_enter and
drm_dev_exit pair to avoid mixing paradigms here?

> @@ -204,7 +218,10 @@ int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offse
>  
>  	xe_pm_runtime_put(xe);
>  
> -	return count;
> +dev_exit:
> +	drm_dev_exit(idx);
> +
> +	return ret == 0 ? count : ret;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923181115.2514193-22-michael.j.ruhl@intel.com?part=10