All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srish Srinivasan <ssrish@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, nayna@linux.ibm.com,
	gjoyce@linux.ibm.com, ritesh.list@gmail.com,
	sshegde@linux.ibm.com, linux-kernel@vger.kernel.org,
	rnsastry@linux.ibm.com, ssrish@linux.ibm.com,
	stable@vger.kernel.org
Subject: [PATCH 03/12] pseries/plpks: validate input to plpks_signed_update_var()
Date: Wed, 23 Sep 2026 23:58:07 +0530	[thread overview]
Message-ID: <20260923182816.151451-4-ssrish@linux.ibm.com> (raw)
In-Reply-To: <20260923182816.151451-1-ssrish@linux.ibm.com>

plpks_signed_update_var() dereferences the supplied PLPKS variable pointer
without validating it. A NULL argument could therefore result in a NULL
pointer dereference.

Reject a NULL pointer argument with -EINVAL.

Fixes: 899d9b8fee66 ("powerpc/pseries: Implement signed update for PLPKS objects")
Cc: stable@vger.kernel.org # 6.3
Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/plpks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
index ccf5765a907b..e3ae2cd78247 100644
--- a/arch/powerpc/platforms/pseries/plpks.c
+++ b/arch/powerpc/platforms/pseries/plpks.c
@@ -637,6 +637,9 @@ int plpks_signed_update_var(struct plpks_var *var, u64 flags)
 	u64 continuetoken = 0;
 	u64 timeout = 0;
 
+	if (!var)
+		return -EINVAL;
+
 	if (!var->data || var->datalen <= 0 || var->namelen > PLPKS_MAX_NAME_SIZE)
 		return -EINVAL;
 
-- 
2.52.0



  parent reply	other threads:[~2026-09-23 18:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 18:28 [PATCH 00/12] Refactor and harden PLPKS code Srish Srinivasan
2026-09-23 18:28 ` [PATCH 01/12] pseries/plpks: fix error handling in plpks_read_var() Srish Srinivasan
2026-09-23 18:28 ` [PATCH 02/12] pseries/plpks: fix error code for wrapping key reads Srish Srinivasan
2026-09-23 18:28 ` Srish Srinivasan [this message]
2026-09-23 18:28 ` [PATCH 04/12] pseries/plpks: clear sensitive PLPKS buffers Srish Srinivasan
2026-09-23 18:28 ` [PATCH 05/12] pseries/plpks: clear sensitive buffers in wrapping operations Srish Srinivasan
2026-09-23 18:28 ` [PATCH 06/12] pseries/plpks: clear signed update authentication buffer Srish Srinivasan
2026-09-23 18:28 ` [PATCH 07/12] pseries/plpks: clear SED key data after use Srish Srinivasan
2026-09-23 18:28 ` [PATCH 08/12] pseries/plpks: fix self-reference in plpks_var initializer Srish Srinivasan
2026-09-23 18:28 ` [PATCH 09/12] pseries/plpks: hide wrapping_features when unsupported Srish Srinivasan
2026-09-23 18:28 ` [PATCH 10/12] pseries/plpks: make narrowing conversions explicit Srish Srinivasan
2026-09-23 18:28 ` [PATCH 11/12] pseries/plpks: rename the default wrapping key macro Srish Srinivasan
2026-09-23 18:28 ` [PATCH 12/12] pseries/plpks: update PKS documentation and MAINTAINERS entry Srish Srinivasan
2026-10-12  3:31 ` [PATCH 00/12] Refactor and harden PLPKS code Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923182816.151451-4-ssrish@linux.ibm.com \
    --to=ssrish@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=gjoyce@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=rnsastry@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.