Re: [PATCH] dt-bindings: pinctrl: convert nsp-gpio binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: pinctrl: brcm,nsp-gpio drops gpio-hog and forces double nesting
--

commit 25a9276749a1169691e6667beb90f7132674e886
Author: Rosen Penev <rosenp@gmail.com>

dt-bindings: pinctrl: convert nsp-gpio binding

The brcm,nsp-gpio-a compatible used by the NSP GPIO controller was
only documented in the legacy text binding, so dtbs_check reported
'failed to match any schema' for the gpio@20 node present in every
bcm958625 and related board DTS.

Convert Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.txt
to a YAML schema and drop the text binding. Keep the existing
required and optional properties (reg, #gpio-cells, gpio-controller,
ngpios, and the optional interrupt/gpio-ranges support), including
the generic pinconf child nodes with pin bias and drive-strength.

> diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,nsp-gpio.yaml

[ ... ]

> +patternProperties:
> +  '-pins$':
> +    type: object
> +    additionalProperties:
> +      description: Pin configuration child nodes.
> +      allOf:
> +        - $ref: pincfg-node.yaml#

[Severity: Medium]
Does this pattern property enforce a double-level nesting by treating
-pins nodes as wrapper objects where the properties are the actual pin
configuration nodes?

This breaks documented single-level dts configurations from the previous
text binding.

[ ... ]

> +        drive-strength:
> +          enum: [ 2, 4, 6, 8, 10, 12, 14, 16 ]
> +
> +      required:
> +        - pins
> +
> +additionalProperties: false

[Severity: Medium]
Does using strict additionalProperties: false without referencing core schemas
like gpio-hog or using unevaluatedProperties: false cause standard gpio-hog
nodes and root pinctrl properties to be improperly rejected?

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    gpio@18000020 {
> +        compatible = "brcm,nsp-gpio-a";
> +        reg = <0x18000020 0x100>,
> +              <0x1803f1c4 0x1c>;

[ ... ]

> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +        interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> +
> +        led-pins {
> +            led {
> +                pins = "gpio-1";
> +                bias-pull-up;
> +            };
> +        };
> +    };

[Severity: Medium]
Does altering the example to drop the gpio-hog node and pinctrl-0
properties, while artificially wrapping the led node, bypass schema validation
errors that would have otherwise caught the above issues?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923185305.26223-1-rosenp@gmail.com?part=1