From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua2-f43.google.com (mail-ua2-f43.google.com [74.125.226.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5993B54A7ED for ; Wed, 23 Sep 2026 19:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.226.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790191929; cv=none; b=VRVN/aAK7AR+phisWb7YUcKzEwnJceEfFXTqXrKWCxzARqzfDHhFDfWwsOSVs1Oe5+JtN8PyM0s+ujJXGsgXR3i2xsu/UwXUQhE13ZFajXa8/mHUqcX8fgCUCZvIlKYLafU+hFQzOEe+jJ6zm2h9LFS1f18b5xpQ+u18f8Sdms4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790191929; c=relaxed/simple; bh=xq8sOK+jqVXt+sGUzSaDD3mz3kqYi0uamMWLGLnbwfQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QInfx28rsqPB5ssQW95cd6c7msgzvEeQdiwOp7s6IQdFvc6xIJQqBwBy4o6dO0oI3tcCMphayjIVVJv+HtXU8rBzZNVdh6NN+878FSCk6nThGxWRT4AL3bcOLEuhpKHbIsQgpz/enloMFzHwX4nxHhZhF6H1ALhmNlPBggpoUpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l0b6lH/O; arc=none smtp.client-ip=74.125.226.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l0b6lH/O" Received: by mail-ua2-f43.google.com with SMTP id a1e0cc1a2514c-98334af2ca0so454559241.3 for ; Wed, 23 Sep 2026 12:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790191927; x=1790796727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=WRUO4dGD9GwElU1wEz0nQz+wfMYIGrewnknxx+MgLf8=; b=l0b6lH/OzLUN3hy3aeOBn1KDClxh9HA+mAUbuoZWzVID6rVf+yY6fVzH3QuXIJdEB6 jAxqjBcD1i/PTZ2/hEsbxlb4+DrlcTiNTm79MYYfQZypislBGTgruc+q8tPeIQQbyaro WlqDhZdW0sqa2xgFsdaXzDzbVtJpj6G22/lF7gD6FM2BMOLd5nNUqKT6AKSSDGiA8iwa Uv/rw/O2ZYBsnap1miPNCRioK+TzBw4dIvknJcrYBtKea4GW/uOBMMEJLFhU4FNtKA37 v1mrWMw0ghdqWUzprQSMYwc2BqdM3l5/r5KBFfYowAjb7ifFARXMEgSfSMCH17kugBNZ CG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790191927; x=1790796727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=WRUO4dGD9GwElU1wEz0nQz+wfMYIGrewnknxx+MgLf8=; b=JRX7Ttga7IJPSeXegpO5+Mp0H3uS85oYxj+C5cYRAUAVeu1xmGVDbNgNl0BsrGQLDS anXehf4tbA9ubFFwUjsPmBs3GB71coLLAoEDaQ2IAkvfM0qkcVkOLJnUzaVPMuG8CHg4 uHYAULVk8PIeAxtl6WQtmbGFoZyUbftXghnuzrrzwAXgYYPxDJzCZti/59587qXj3KBc CD32RIu9j+EmX3fBmSbbNLmsocpS+rUwEK0zgimeeZHvtX9Pa3grhbeBhiltq4EoVMrn j1TEtxmesH6v8WfYxs+lGABi+hc8kEV2ZdcYrFbGtm7t96qtFjZ+L2nSpkJ0Jl75kc+A NEfA== X-Gm-Message-State: AFuF++mWnaqe/m2UcFhbGGQHW6XTLET3CvxG48aRZjIai5re//ZOnOiQ n99QR7P9Rk1TmrteW3t3UWKVvfDBrZKheHpSOlASaWNlndh1XGY/qNjwqs+zl/A1uk5O0g== X-Gm-Gg: AYBFou3QQ1V7LfBYTmR9xUD9dekEg+JLCWsYuXcHqdv4OHsBZDGv4DVMBnRR59Pk9WM 9TBT0Sp5n91oAFcuUOHMVAJnijpU5bpmfysfqv+Q72MqWKJ47CRAtB5K/SxuXC9oaknzDi0h+hW pb/bzzR77PIUoIYQWZx339Iw+8Q5CxkHe6F+PkICQNu88scf1KyKWqu6OsGO/nLYlLj7tEk75d/ K1ckw2ce4EcomK3Uyy05hzzfVKH3oxEvNo+nWfCZuaGIVNpD7aB6MZxu0r3xI4BTF3lmxtG6qCj KZafOyEicQPtP4bmFYBRPnh00ZI1Y5uxspKB0PDBMR3ymMosxio8npCis81iBKffJA/5LBwzPYZ 1pliEkjgnsIyH06aJ4yDFNwEnk981SQSupbpnphj8dGlf4VhQhEDnCfMsDmW1Z/b26Hq1WfrrC0 QjwVz+nMVxtcdgSaWs2QZejdYPe8o7iZyxxyDFhtiz/PgBcONetTuqUu6qmpM6Ysw0Ctb5sLalY aQyJgm5S69O4YHPgFMN+XF1pvRf8TLQYbP5rSZBvNVkgdgLl0HE6mYrfTx5H7DH X-Received: by 2002:a05:6102:291e:b0:7af:51a:de01 with SMTP id ada2fe7eead31-7af1d4bd641mr205873137.19.1790191927257; Wed, 23 Sep 2026 12:32:07 -0700 (PDT) Received: from lvondent-mobl5 ([72.188.211.115]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9851691693asm4666266241.2.2026.09.23.12.32.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 12:32:06 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ v1 3/7] emulator: Default to the latest BR/EDR+LE version Date: Wed, 23 Sep 2026 15:31:53 -0400 Message-ID: <20260923193157.249636-4-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923193157.249636-1-luiz.dentz@gmail.com> References: <20260923193157.249636-1-luiz.dentz@gmail.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luiz Augusto von Dentz Emulate BR/EDR+LE 6.2 controllers by default, for both local (-l) and server (--server, --tcp) controllers, so the latest features such as Shorter Connection Intervals (LE Connection Rate Request) are supported, e.g. by test-functional which uses --server. Add the -C/--core= option to emulate older versions instead: 5.0, 5.2, 6.0 or 6.2. --- emulator/main.c | 54 ++++++++++++++++++++++++++++++++++++++++++++--- emulator/server.c | 15 ++++++++++++- emulator/server.h | 2 ++ 3 files changed, 67 insertions(+), 4 deletions(-) diff --git a/emulator/main.c b/emulator/main.c index c21640adc359..b18e77cf191b 100644 --- a/emulator/main.c +++ b/emulator/main.c @@ -24,8 +24,8 @@ #include "src/shared/util.h" #include "serial.h" -#include "server.h" #include "btdev.h" +#include "server.h" #include "vhci.h" #include "le.h" @@ -54,6 +54,9 @@ static void usage(void) "\t-U[num] Number of test LE controllers\n" "\t-B Create BR/EDR only controller\n" "\t-A Create AMP controller\n" + "\t-C, --core= Core Specification version of the\n" + "\t BR/EDR/LE controllers:\n" + "\t 5.0, 5.2, 6.0 or 6.2 (default)\n" "\t-T[num] Number of test AMP controllers\n" "\t-h, --help Show help options\n"); } @@ -67,12 +70,37 @@ static const struct option main_options[] = { { "le", no_argument, NULL, 'L' }, { "bredr", no_argument, NULL, 'B' }, { "amp", no_argument, NULL, 'A' }, + { "core", required_argument, NULL, 'C' }, { "letest", optional_argument, NULL, 'U' }, { "version", no_argument, NULL, 'v' }, { "help", no_argument, NULL, 'h' }, { } }; +static const struct { + const char *version; + enum btdev_type type; +} core_versions[] = { + { "5.0", BTDEV_TYPE_BREDRLE50 }, + { "5.2", BTDEV_TYPE_BREDRLE52 }, + { "6.0", BTDEV_TYPE_BREDRLE60 }, + { "6.2", BTDEV_TYPE_BREDRLE62 }, +}; + +static bool parse_core_version(const char *version, enum btdev_type *type) +{ + size_t i; + + for (i = 0; i < ARRAY_SIZE(core_versions); i++) { + if (!strcmp(core_versions[i].version, version)) { + *type = core_versions[i].type; + return true; + } + } + + return false; +} + static void vhci_debug(const char *str, void *user_data) { int i = PTR_TO_UINT(user_data); @@ -101,7 +129,10 @@ int main(int argc, char *argv[]) bool serial_enabled = false; int letest_count = 0; int vhci_count = 0; - enum btdev_type type = BTDEV_TYPE_BREDRLE60; + /* Default to the latest version supported by the emulator */ + enum btdev_type bredrle_type = BTDEV_TYPE_BREDRLE62; + enum btdev_type type; + bool type_set = false; int i; mainloop_init(); @@ -109,7 +140,7 @@ int main(int argc, char *argv[]) for (;;) { int opt; - opt = getopt_long(argc, argv, "dSs::t::l::LBAU::T::vh", + opt = getopt_long(argc, argv, "dSs::t::l::LBAC:U::T::vh", main_options, NULL); if (opt < 0) break; @@ -140,12 +171,22 @@ int main(int argc, char *argv[]) break; case 'L': type = BTDEV_TYPE_LE; + type_set = true; break; case 'B': type = BTDEV_TYPE_BREDR; + type_set = true; break; case 'A': type = BTDEV_TYPE_AMP; + type_set = true; + break; + case 'C': + if (!parse_core_version(optarg, &bredrle_type)) { + fprintf(stderr, "Unsupported version: %s\n", + optarg); + return EXIT_FAILURE; + } break; case 'U': if (optarg) @@ -164,6 +205,9 @@ int main(int argc, char *argv[]) } } + if (!type_set) + type = bredrle_type; + if (letest_count < 1 && vhci_count < 1 && !server_enabled && !tcp_port && !serial_enabled) { fprintf(stderr, "No emulator specified\n"); @@ -214,6 +258,8 @@ int main(int argc, char *argv[]) server1 = server_open_unix(SERVER_TYPE_BREDRLE, path); if (!server1) fprintf(stderr, "Failed to open BR/EDR/LE server\n"); + else + server_set_bredrle_type(server1, bredrle_type); snprintf(path, sizeof(path), "%s/%s", server_path, "bt-server-bredr"); @@ -255,6 +301,8 @@ int main(int argc, char *argv[]) tcp_server = server_open_tcp(SERVER_TYPE_BREDRLE, tcp_port); if (!tcp_server) fprintf(stderr, "Failed to open TCP port\n"); + else + server_set_bredrle_type(tcp_server, bredrle_type); fprintf(stderr, "Listening TCP on 127.0.0.1:%d\n", tcp_port); } diff --git a/emulator/server.c b/emulator/server.c index e3eda8458ae0..5a827b24531e 100644 --- a/emulator/server.c +++ b/emulator/server.c @@ -38,6 +38,7 @@ struct server { enum server_type type; + enum btdev_type bredrle_type; uint16_t id; int fd; struct queue *clients; @@ -281,7 +282,7 @@ static void server_accept_callback(int fd, uint32_t events, void *user_data) switch (server->type) { case SERVER_TYPE_BREDRLE: - type = BTDEV_TYPE_BREDRLE52; + type = server->bredrle_type; break; case SERVER_TYPE_BREDR: type = BTDEV_TYPE_BREDR; @@ -361,6 +362,7 @@ struct server *server_open_unix(enum server_type type, const char *path) memset(server, 0, sizeof(*server)); server->type = type; + server->bredrle_type = BTDEV_TYPE_BREDRLE62; server->id = 0x42; server->fd = open_unix(path); @@ -429,6 +431,7 @@ struct server *server_open_tcp(enum server_type type, uint16_t port) memset(server, 0, sizeof(*server)); server->type = type; + server->bredrle_type = BTDEV_TYPE_BREDRLE62; server->id = 0x43; server->fd = open_tcp(port); @@ -455,6 +458,16 @@ void server_close(struct server *server) mainloop_remove_fd(server->fd); } +bool server_set_bredrle_type(struct server *server, enum btdev_type type) +{ + if (!server || server->type != SERVER_TYPE_BREDRLE) + return false; + + server->bredrle_type = type; + + return true; +} + bool server_set_debug(struct server *server, server_debug_func_t callback, void *user_data, server_destroy_func_t destroy) { diff --git a/emulator/server.h b/emulator/server.h index 1844a9871af1..5fc3a284f53f 100644 --- a/emulator/server.h +++ b/emulator/server.h @@ -25,6 +25,8 @@ struct server *server_open_unix(enum server_type type, const char *path); struct server *server_open_tcp(enum server_type type, uint16_t port); void server_close(struct server *server); +bool server_set_bredrle_type(struct server *server, enum btdev_type type); + typedef void (*server_debug_func_t)(const char *str, void *user_data); typedef void (*server_destroy_func_t)(void *user_data); bool server_set_debug(struct server *server, server_debug_func_t callback, -- 2.55.0