From: sashiko-bot@kernel.org
To: "Namhyung Kim" <namhyung@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/3] perf test: Fix record tests on Intel Broadwell
Date: Wed, 23 Sep 2026 22:01:14 +0000 [thread overview]
Message-ID: <20260923220115.341881F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923215255.3329181-2-namhyung@kernel.org>
> I noticed it failed for leader sampling tests on Broadwell. It's
> because the period of groups members are a little bit different. Maybe
> there's an hardware issue but anyway it's close enough to treat them as
> same. I printed the value like below.
>
> $ perf test record
> ...
> prev: 462507, curr: 462506
> prev: 494783, curr: 494782
> prev: 454350, curr: 454349
> prev: 502782, curr: 502781
> prev: 566693, curr: 566692
> prev: 606558, curr: 606557
> prev: 559770, curr: 559769
> prev: 595737, curr: 595736
> prev: 643386, curr: 643385
> prev: 663672, curr: 663671
> prev: 620622, curr: 620621
> prev: 650419, curr: 650418
> Leader sampling [Failed inconsistent cycles count]
>
> Let's update the logic to compare values to allow 1% of errors.
>
> Also I think it should compare only if sees the non-leader samples so
> split the check of (($index % 2)).
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923215255.3329181-1-namhyung@kernel.org?part=2
next prev parent reply other threads:[~2026-09-23 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 21:52 [PATCH 1/3] perf test: Fix errors when deleting data in perf record tests Namhyung Kim
2026-09-23 21:52 ` [PATCH 2/3] perf test: Fix record tests on Intel Broadwell Namhyung Kim
2026-09-23 22:01 ` sashiko-bot [this message]
2026-09-24 3:45 ` Ian Rogers
2026-09-24 6:55 ` Mi, Dapeng
2026-09-23 21:52 ` [PATCH 3/3] perf test: Fix record tests on hybrid machines Namhyung Kim
2026-09-23 21:59 ` sashiko-bot
2026-09-24 3:44 ` Ian Rogers
2026-09-23 22:00 ` [PATCH 1/3] perf test: Fix errors when deleting data in perf record tests sashiko-bot
2026-09-24 3:39 ` Ian Rogers
2026-09-25 10:51 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923220115.341881F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.