From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,kasong@tencent.com,akpm@linux-foundation.org
Subject: [to-be-updated] mm-huge_memory-drop-the-unused-do_lru-argument-of-the-file-split-helper.patch removed from -mm tree
Date: Wed, 23 Sep 2026 15:23:24 -0700 [thread overview]
Message-ID: <20260923222324.E36721F000FF@smtp.kernel.org> (raw)
The quilt patch titled
Subject: mm/huge_memory: drop the unused do_lru argument of the file split helper
has been removed from the -mm tree. Its filename was
mm-huge_memory-drop-the-unused-do_lru-argument-of-the-file-split-helper.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Kairui Song <kasong@tencent.com>
Subject: mm/huge_memory: drop the unused do_lru argument of the file split helper
Date: Tue, 15 Sep 2026 01:14:55 +0800
The only caller of __folio_freeze_split_file() always passes do_lru as
true, so the argument and the branches gated on it are dead code. Drop
it.
Link: https://lore.kernel.org/20260915-swap-thp-cleanup-v5-14-39878b37dfb0@tencent.com
Signed-off-by: Kairui Song <kasong@tencent.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Baoquan He <baoquan.he@linux.dev>
Cc: Barry Song <baohua@kernel.org>
Cc: Chris Li <chrisl@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>
---
mm/huge_memory.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
--- a/mm/huge_memory.c~mm-huge_memory-drop-the-unused-do_lru-argument-of-the-file-split-helper
+++ a/mm/huge_memory.c
@@ -4133,8 +4133,7 @@ out_unlock:
static int __folio_freeze_split_file(struct folio *folio,
unsigned int new_order, struct page *split_at,
- bool do_lru, struct list_head *list,
- enum split_type split_type)
+ struct list_head *list, enum split_type split_type)
{
struct address_space *mapping = folio->mapping;
XA_STATE(xas, &mapping->i_pages, folio->index);
@@ -4228,9 +4227,7 @@ static int __folio_freeze_split_file(str
}
/* lock lru list/PageCompound, ref frozen by page_ref_freeze */
- if (do_lru)
- lruvec = folio_lruvec_lock(folio);
-
+ lruvec = folio_lruvec_lock(folio);
ret = __split_frozen_folio(folio, new_order, split_at, &xas,
mapping, split_type);
@@ -4252,8 +4249,7 @@ static int __folio_freeze_split_file(str
folio_ref_unfreeze(new_folio,
folio_cache_ref_count(new_folio) + 1);
- if (do_lru)
- lru_add_split_folio(folio, new_folio, lruvec, list);
+ lru_add_split_folio(folio, new_folio, lruvec, list);
/* Add the new folio to the page cache. */
if (new_folio->index < end) {
@@ -4279,9 +4275,7 @@ static int __folio_freeze_split_file(str
* and its caller can see stale page cache entries.
*/
folio_ref_unfreeze(folio, folio_cache_ref_count(folio) + 1);
-
- if (do_lru)
- lruvec_unlock(lruvec);
+ lruvec_unlock(lruvec);
fail:
/*
* If we want to use try_to_migrate() on file in unmap_folio,
@@ -4361,7 +4355,7 @@ static int __folio_split(struct folio *f
true, list, split_type);
else
ret = __folio_freeze_split_file(folio, new_order, split_at,
- true, list, split_type);
+ list, split_type);
/*
* Unlock all after-split folios except the one containing
_
Patches currently in -mm which might be from kasong@tencent.com are
mm-memcontrol-move-the-lru_zone_size-sanity-check-to-the-reader-side.patch
mm-mglru-introduce-helpers-for-manipulating-gen-and-refs-flags.patch
mm-migrate-copy-all-referenced-state-via-folio_migrate_lru_refs.patch
mm-mglru-move-max_seq-read-into-walk_update_folio.patch
mm-mglru-use-explicit-tier-range-in-read_ctrl_pos.patch
mm-mglru-fix-potential-generation-folio-number-leak.patch
mm-huge_memory-clean-up-after-split-folio-freeing-in-__folio_split.patch
mm-huge_memory-count-only-swap-cache-refs-in-anon-folio-split.patch
mm-huge_memory-drop-the-redundant-mapping-argument-of-__split_frozen_folio.patch
reply other threads:[~2026-09-23 22:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923222324.E36721F000FF@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=kasong@tencent.com \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.