From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1] perf test: Fix PMU metric parsing tests for unknown literals
Date: Wed, 23 Sep 2026 22:52:31 +0000 [thread overview]
Message-ID: <20260923225232.33F4F1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923224106.3268925-1-irogers@google.com>
> On ARM the #slots literal may or may not be present, it won't be
> present on x86. As it is missing it causes the ampereone and
> ampereonex PMU metric tests to fail when run say on x86. Extend the
> fake_pmu logic so that in these test cases we fake the unknown
> literals like #slots as 1.0. When building with JEVENTS_ARCH=all the
> ampere metric tests no longer fail.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923224106.3268925-1-irogers@google.com?part=1
next prev parent reply other threads:[~2026-09-23 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 22:41 [PATCH v1] perf test: Fix PMU metric parsing tests for unknown literals Ian Rogers
2026-09-23 22:52 ` sashiko-bot [this message]
2026-09-25 10:53 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923225232.33F4F1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.