From: Jason Gunthorpe <jgg@nvidia.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, will@kernel.org,
robin.murphy@arm.com, joro@8bytes.org, nicolinc@nvidia.com,
praan@google.com
Subject: Re: [PATCH 0/7] iommu/arm-smmu-v3: Fixes reported by Sashiko
Date: Wed, 23 Sep 2026 21:03:44 -0300 [thread overview]
Message-ID: <20260924000344.GA3560397@nvidia.com> (raw)
In-Reply-To: <20260828125409.1921538-1-smostafa@google.com>
On Fri, Aug 28, 2026 at 12:53:35PM +0000, Mostafa Saleh wrote:
> While running sashiko locally on the pKVM SMMUv3 driver patches, it
> reported some pre-existing issues in the SMMUv3 driver (the RB tree
> corruption and a missing NULL check) and given that this is not the
> first time a pre-existing issue appears in the driver from sashiko,
> I went ahead and passed the whole driver to Sashiko which reported a
> dozen of other issues(except the last one in this series), I included
> fixes for bugs I believe are true or worth fixing (others were mostly
> missing NULL checks or bizarre HW/FW configs I don’t think are needed).
>
> I also sorted the patches based on severity from the most critical to
> the least, so it is easier to apply a prefix if some bugs are too
> theoretical
>
> Mostafa Saleh (7):
> iommu/arm-smmu-v3: Ensure L2 tables are visible before L1 ptrs
> iommu/arm-smmu-v3: Prevent rbtree corruption from duplicate streams
> iommu/arm-smmu-v3-iommufd: Fix error path in
> arm_vsmmu_cache_invalidate()
> iommu/arm-smmu-v3-test: Fix arm_smmu_v3_test_debug_print_used_bits()
> iommu/arm-smmu-v3-test: Add missing error checks for inv array
> iommu/arm-smmu-v3-test: Fix OOB in arm_smmu_v3_invs_test_verify()
> iommu/arm-smmu-v3-test: Fix UBSAN error
Does this need a respin? At least the 3rd patch there should no go
as the iommufd tree has a different version of that fix now
Jason
next prev parent reply other threads:[~2026-09-24 0:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 12:53 [PATCH 0/7] iommu/arm-smmu-v3: Fixes reported by Sashiko Mostafa Saleh
2026-08-28 12:53 ` [PATCH 1/7] iommu/arm-smmu-v3: Ensure L2 tables are visible before L1 ptrs Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:03 ` Nicolin Chen
2026-08-28 12:53 ` [PATCH 2/7] iommu/arm-smmu-v3: Prevent rbtree corruption from duplicate streams Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 15:51 ` Nicolin Chen
2026-09-01 8:44 ` Mostafa Saleh
2026-08-28 12:53 ` [PATCH 3/7] iommu/arm-smmu-v3-iommufd: Fix error path in arm_vsmmu_cache_invalidate() Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-09-01 8:47 ` Mostafa Saleh
2026-08-28 12:53 ` [PATCH 4/7] iommu/arm-smmu-v3-test: Fix arm_smmu_v3_test_debug_print_used_bits() Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:12 ` Nicolin Chen
2026-08-28 12:53 ` [PATCH 5/7] iommu/arm-smmu-v3-test: Add missing error checks for inv array Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-09-01 8:51 ` Mostafa Saleh
2026-08-28 12:53 ` [PATCH 6/7] iommu/arm-smmu-v3-test: Fix OOB in arm_smmu_v3_invs_test_verify() Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:14 ` Nicolin Chen
2026-08-28 12:53 ` [PATCH 7/7] iommu/arm-smmu-v3-test: Fix UBSAN error Mostafa Saleh
2026-08-28 14:27 ` Jason Gunthorpe
2026-08-28 16:14 ` Nicolin Chen
2026-09-24 0:03 ` Jason Gunthorpe [this message]
2026-09-24 8:18 ` [PATCH 0/7] iommu/arm-smmu-v3: Fixes reported by Sashiko Mostafa Saleh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924000344.GA3560397@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.