Re: [PATCH RFC net-next 6/9] dt-bindings: net: qcom,ethqos: add Qualcomm Nord

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing clock constraint restriction for older ethqos devices
--

commit 2ec6ff874b6b04da419dd5b3f1e6b8a59de089ce
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

dt-bindings: net: qcom,ethqos: add Qualcomm Nord

This commit adds the Qualcomm Nord compatible string to the qcom,ethqos
binding schema. It updates the constraints to support the new variant's
requirement for 5 clocks, 1 power domain, and 10 SMMU stream mappings.

> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 423959cb928d9..41de2ccd56458 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
[ ... ]
>  allOf:
>    - $ref: snps,dwmac.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,nord-ethqos
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 5
> +          maxItems: 5
> +        clock-names:
> +          minItems: 5
> +          maxItems: 5
> +        iommus:
> +          minItems: 10
> +          maxItems: 10
> +      required:
> +        - power-domains
> +    else:
> +      properties:
> +        iommus:
> +          maxItems: 1

[Severity: Medium]
Since the global constraints for clocks and clock-names are relaxed later in
this file to allow up to 5 items, does this else block also need to restrict
clocks and clock-names back to a maximum of 4 items?

Without this restriction in the else block, device trees for older hardware
generations might silently pass validation even if incorrectly configured
with 5 clocks.

[ ... ]
> @@ -57,19 +80,31 @@ properties:
>        - const: sfty
>  
>    clocks:
> -    maxItems: 4
> +    minItems: 4
> +    maxItems: 5
>  
>    clock-names:
> -    items:
> -      - const: stmmaceth
> -      - const: pclk
> -      - const: ptp_ref
> -      - enum:
> -          - rgmii
> -          - phyaux
> +    oneOf:
> +      - items:
> +          - const: stmmaceth
> +          - const: pclk
> +          - const: ptp_ref
> +          - const: phyaux
> +          - const: eee
> +            description: |
> +              Due to a hardware quirk, PCS link-up depends on the EEE clock
> +              being enabled.
> +      - items:
> +          - const: stmmaceth
> +          - const: pclk
> +          - const: ptp_ref
> +          - enum:
> +              - rgmii
> +              - phyaux

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-qcom_xpcs_nord_emac-v1-0-4b1c682af70f@oss.qualcomm.com?part=6