From: Stefan Berger <stefanb@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: armenon@redhat.com, marcandre.lureau@gmail.com,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH 02/10] tpm_emulator: Reject TPM responses whose size is too small
Date: Wed, 23 Sep 2026 21:25:19 -0400 [thread overview]
Message-ID: <20260924012527.858527-3-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20260924012527.858527-1-stefanb@linux.ibm.com>
Reject a response from the TPM emulator whose size field indicates that the
response is smaller than the size of the header.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
backends/tpm/tpm_emulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c
index 16ae44c8d7..9c95b4d878 100644
--- a/backends/tpm/tpm_emulator.c
+++ b/backends/tpm/tpm_emulator.c
@@ -202,13 +202,13 @@ static int tpm_emulator_unix_tx_bufs(TPMEmulator *tpm_emu,
* size)
*/
to_read = tpm_cmd_get_size(out);
- if (to_read > out_len) {
+ if (to_read > out_len || to_read < sizeof(struct tpm_resp_hdr)) {
if (qio_channel_shutdown(tpm_emu->data_ioc, QIO_CHANNEL_SHUTDOWN_BOTH,
&local_err) < 0) {
error_report_err(local_err);
}
error_setg(errp, "tpm-emulator: Disconnected after receiving "
- "unacceptable large response (%u > %u)",
+ "unacceptable response size (%u max: %u)",
to_read, out_len);
return -1;
}
--
2.55.0
next prev parent reply other threads:[~2026-09-24 1:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 1:25 [PATCH 00/10] Fix a couple of issues in TPM related code Stefan Berger
2026-09-24 1:25 ` [PATCH 01/10] tpm_util: Pass TPMVersion to function writing fatal error response Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 13:23 ` Stefan Berger
2026-09-24 1:25 ` Stefan Berger [this message]
2026-09-24 7:41 ` [PATCH 02/10] tpm_emulator: Reject TPM responses whose size is too small marcandre.lureau
2026-09-24 1:25 ` [PATCH 03/10] tpm_emulator: Reject sending commands smaller than the request header Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 13:24 ` Stefan Berger
2026-09-24 1:25 ` [PATCH 04/10] hw/tpm: tis: Only read from response buffer if rw_offset < len Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 13:34 ` Stefan Berger
2026-09-24 1:25 ` [PATCH 05/10] hw/tpm: tis: Use uint32_t for len to avoid truncating size of command Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 1:25 ` [PATCH 06/10] hw/tpm: crb: Do not clear internal buffers when backend is busy Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 13:50 ` Stefan Berger
2026-09-24 1:25 ` [PATCH 07/10] hw/tpm: crb: Avoid potential integer underflow Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 1:25 ` [PATCH 08/10] hw/tpm: crb: Free ppi.buf in tpm_crb_unrealize Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 1:25 ` [PATCH 09/10] hw/tpm: crb: Consider response_buffer->len of received response Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
2026-09-24 1:25 ` [PATCH 10/10] tests: Add tests with commands with bad length Stefan Berger
2026-09-24 7:41 ` marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924012527.858527-3-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=armenon@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.