From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF3CAC98304 for ; Thu, 24 Sep 2026 01:27:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x9YDZ-00016z-Qo; Wed, 23 Sep 2026 21:25:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9YDX-00015Q-IR for qemu-devel@nongnu.org; Wed, 23 Sep 2026 21:25:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9YDV-0007LE-1f for qemu-devel@nongnu.org; Wed, 23 Sep 2026 21:25:43 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NNZJH9568617; Thu, 24 Sep 2026 01:25:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=IDQ176Hut0VU5cv9Y osY4OsPnEvKopYP8zycheIkTqU=; b=nQGAfPUe0Vfe82cRt70+V95dMhb0zGHoX nUelpDqmSUvKLDQqt2ZB1cR8O695OnUv2SbMDfCMFRjVH4l9fJMwKlC5pA91lqJo gXF/+YYusvYhCDxEV1qGhM/7AXhVzlfKgqbEWvf7M0GTX/WMNCPMiIbqhjzBrTGI UPB8liQxz9AnQJ7pfFgcZGgnY1Owe90uyNb68hZ0WOCMhWyVL4zYvVxq3uKQeKo0 F6aDUBe+NdDKppA7aCeF3jw8I6H5oXEZqWBdjmn3gbhTz3R1xIjEDyI7p8vLI37p dq88c7v5Hdc+T4E1M/10f/53nGvZpc3IkKfU6kZuVamOWI4e8DtDg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gskgsecum-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 24 Sep 2026 01:25:39 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 68NNI3DL1075258; Thu, 24 Sep 2026 01:25:38 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4gvbu8uf28-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Sep 2026 01:25:38 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 68O1PbcI27853510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Sep 2026 01:25:38 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E34C758059; Thu, 24 Sep 2026 01:25:37 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63A7858053; Thu, 24 Sep 2026 01:25:37 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 24 Sep 2026 01:25:37 +0000 (GMT) From: Stefan Berger To: qemu-devel@nongnu.org Cc: armenon@redhat.com, marcandre.lureau@gmail.com, Stefan Berger Subject: [PATCH 03/10] tpm_emulator: Reject sending commands smaller than the request header Date: Wed, 23 Sep 2026 21:25:20 -0400 Message-ID: <20260924012527.858527-4-stefanb@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260924012527.858527-1-stefanb@linux.ibm.com> References: <20260924012527.858527-1-stefanb@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=V/XoQuni c=1 sm=1 tr=0 ts=6ab47c13 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=qVDuPxsLud46wrm4fkoA:9 X-Proofpoint-ORIG-GUID: 3rOx48Z-YaVSdKXHuIsF3oPC-s3rA-h5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDAwNiBTYWx0ZWRfXwnfBu8OJIyit sOd3pdrYsnZqCx08XVpruFo9mC7Z5T62uDOZ6lNQQTsMMe22xhItMlTQdp3nqcP08ovxvpWECbi DFdtkUiRHTCaPMQG5XM/MKwpRAzuM1zDQlWdWg8SqubC9QsgFv+PRFa1Eg2FVfAMgpzy8Tu3qej Ig/xarrlB+I9cWiwvvjLlJjq5IPi4AlH+i62cgUqtclU06GXTrGNxQeLk6kHahRSdlkKjDISR7U su8n3GDfj1dTOjmsnobxYd/Ik9MYFo9doHple1SY4VAl4HnI81OiZ7Lx5a6xLu3LwwoUQhReao/ k9Lx0iDkWO4kN75OWYcoct/cyAUc40Lt3H2lcAh5fX0sEBU+dvHmYm1jdsbWTHr0DgUOg2hZGqs JXeQo8mCB3CYB31aa3Gy2GHBKquQ5McyLHwIbQTw78A5td8v1cwkmXY7iaXDWATd48XP578nxqX henwDbBt4No7JYNL1cQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDAwNiBTYWx0ZWRfX72tyL3MR6MUR 4M5/q1GVO95WHl66XbPH+I6I2jbK6FV+tYELQrL+q1YwKkNZW+n49uKhfKunT96BqJ6Y4Jgg5Up K6x0nOSG8WcOC+TNhbbnDqCebbYC9Wg= X-Proofpoint-GUID: tVAkbe5bCSEzvNGLvLbz2ZxYkmYiydPN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_08,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240006 Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Reject any TPM request from being sent to the TPM emulator that is shorter than the size of the request header. Fixes: f4ede81eed29 ("tpm: Added support for TPM emulator") Signed-off-by: Stefan Berger --- backends/tpm/tpm_emulator.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index 9c95b4d878..0c9e32f36a 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -181,6 +181,11 @@ static int tpm_emulator_unix_tx_bufs(TPMEmulator *tpm_emu, uint32_t to_read; ssize_t ret; + if (in_len < sizeof(struct tpm_req_hdr)) { + error_setg(errp, "tpm-emulator: invalid request size %u", in_len); + return -1; + } + if (selftest_done) { *selftest_done = false; is_selftest = tpm_util_is_selftest(in, in_len); -- 2.55.0