Re: [PATCH 2/2] configs: spacemit: k3: Enable Ethernet support

[Yixun Lan <dlan@kernel.org>]

On 20:13 Wed 23 Sep     , E Shattow wrote:
> Hi Yixun,
> 
> On 9/23/26 18:53, Yixun Lan wrote:
> > Enable the SpacemiT platform glue for the DesignWare Ethernet QoS
> > controller together with the generic PHY framework, Gigabit Ethernet
> > PHY support and the Realtek PHY driver.
> > 
> > Enable DHCP, MII, ping and PXE commands for network configuration,
> > diagnostics and network boot. Allow U-Boot to generate a random
> > Ethernet address when no valid address is provided by the board.
> > 
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> >  configs/spacemit_k3_defconfig | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/configs/spacemit_k3_defconfig b/configs/spacemit_k3_defconfig
> > index 6ca41aecc41..3a70a0a4858 100644
> > --- a/configs/spacemit_k3_defconfig
> > +++ b/configs/spacemit_k3_defconfig
> > @@ -24,10 +24,15 @@ CONFIG_SYS_PBSIZE=276
> >  CONFIG_HUSH_PARSER=y
> >  CONFIG_CMD_GPIO=y
> >  CONFIG_CMD_I2C=y
> > +CONFIG_CMD_DHCP=y
> > +CONFIG_CMD_MII=y
> > +CONFIG_CMD_PING=y
> > +CONFIG_CMD_PXE=y
> >  CONFIG_CMD_PMIC=y
> >  CONFIG_CMD_REGULATOR=y
> >  CONFIG_CMD_FAT=y
> >  CONFIG_CMD_FS_GENERIC=y
> > +CONFIG_NET_RANDOM_ETHADDR=y
> >  CONFIG_SYSCON=y
> >  CONFIG_CLK_SPACEMIT=y
> >  CONFIG_CLK_SPACEMIT_K3=y
> > @@ -35,6 +40,11 @@ CONFIG_SPACEMIT_GPIO=y
> >  CONFIG_DM_I2C=y
> >  CONFIG_SYS_I2C_SPACEMIT_K1=y
> >  CONFIG_MISC=y
> > +CONFIG_PHY_GIGE=y
> > +CONFIG_DWC_ETH_QOS=y
> > +CONFIG_DWC_ETH_QOS_SPACEMIT=y
> > +CONFIG_PHY_REALTEK=y
> > +CONFIG_PHY=y
> >  CONFIG_PINCTRL=y
> >  CONFIG_PINCTRL_SPACEMIT_K1=y
> >  CONFIG_DM_PMIC=y
> > 
> 
> Please also enable for this series: CMD_WGET DNS NET_LWIP
> 
No objection from my side, can add in next version

> We can intentionally leave WGET_HTTPS behind when there is no
> hardware-specific DM RNG driver implemented yet. I do not see a reason
> for the legacy network stack instead of LwIP; LwIP appears to be working
> well.
> 
Ok

> In my test I start a simple HTTP server on the local network host:
> 
> $ python3 -m http.server 8000
> Serving HTTP on 0.0.0.0 port 8000 (http://0.0.0.0:8000/) ...
> 
> Next from a Sipeed K3 Pico-ITX 32GB board and your mainline u-boot series:
> 
> => dhcp
> ethernet@cac80000 Waiting for PHY auto negotiation to complete........ done
> DHCP client bound to address <10.20.30.40> (38 ms)
> => wget http://host:8000/mini.efi
> ##################################################
> 87962624 bytes transferred in 7414 ms (11.3 MiB/s)
> Bytes transferred = 87962624 (53e3400 hex)
> 
> With that,
> 
> Tested-by: E Shattow <e@freeshell.de>

Thanks for testing, will apply your tag to the series

-- 
Yixun Lan (dlan)