Re: [PATCH bluetooth-next v4 3/3] Bluetooth: btaic: Add AIC8800D80 SDIO loader and UART transport

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] bluetooth: btaic: unused suspend/resume functions when !CONFIG_PM_SLEEP
--

commit 774c6b59e34be9758b37b2fc097ca43acb716194
Author: Yanli Yang <yanli.yang@bedmex.com>

Bluetooth: btaic: Add AIC8800D80 SDIO loader and UART transport

This commit adds a driver for the AIC8800D80 Bluetooth chip, utilizing SDIO
function 1 for firmware loading and a serdev UART interface for the HCI
transport. It coordinates the firmware provider and UART consumer through a
reference-counted boot state.

> diff --git a/drivers/bluetooth/btaic_sdio.c b/drivers/bluetooth/btaic_sdio.c
> new file mode 100644
> index 0000000000000..18d58f0832a5a
> --- /dev/null
> +++ b/drivers/bluetooth/btaic_sdio.c
[ ... ]
> +static int aic_bt_sdio_suspend(struct device *dev)
> +{
> +	struct sdio_func *func = dev_to_sdio_func(dev);
> +	mmc_pm_flag_t caps;
> +
> +	caps = sdio_get_host_pm_caps(func);
> +	if (!(caps & MMC_PM_KEEP_POWER))
> +		return -EOPNOTSUPP;
> +
> +	return sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
> +}
> +
> +static int aic_bt_sdio_resume(struct device *dev)
> +{
> +	return 0;
> +}

[Severity: Low]
Will compiling this driver with CONFIG_PM_SLEEP disabled trigger
unused-function build warnings?

When CONFIG_PM_SLEEP is not set, SET_SYSTEM_SLEEP_PM_OPS expands to nothing,
leaving aic_bt_sdio_suspend and aic_bt_sdio_resume unreferenced in this
file. Adding the __maybe_unused attribute to these static functions would
prevent the warnings.

> +
> +static const struct dev_pm_ops aic_bt_sdio_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(aic_bt_sdio_suspend, aic_bt_sdio_resume)
> +};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179022103315.2.2907053891316619435.btaic-v4-cover@bedmex.com?part=3