From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A01C5411A0A for ; Thu, 24 Sep 2026 04:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790223376; cv=none; b=TcfWjEC6nvShqfx9TLNPIUs1DpULtntB8OKFwP1ivFwTeQT2KPXe6gh/1/qWf5ZqaJXyXmFjv2JSaek5rqLMqhDoiLkoeGKM8kWFmkmJTMKRQQNcrzzRIkr+a1YG3/fAKLSk+LKASrS6+jUxiGdu8V+ZE+nJ/L8SJTxiJVcmSmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790223376; c=relaxed/simple; bh=4mNQWbChJAgFDbg2bTs/RQS9DczFtsrEoJsv+d9jZf8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Je80e0vkiF3kJL5uQM/tK3sA0x83pEealKiq9LhbXoigwIVpUrhhweYQqbwzXQvb4VpJUNe9vFtvOQoYl2LyExrHQ7RqlCwNpQFRyfgnhhXdTt74JTKIyy3F0cyw3eHBTA1aGWWxyxPUqVmODwpDYNqHGBATM1fxmfqioxgOSdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--avagin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JQdDFhUI; arc=none smtp.client-ip=209.85.210.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--avagin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JQdDFhUI" Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-804e73b36eeso2818214a34.2 for ; Wed, 23 Sep 2026 21:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790223370; x=1790828170; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pLR8sISmsxHCx8KzZxnkzJcWho2PP8br9Rps/xb8c2M=; b=JQdDFhUIwkns3RT7k9L9d1pne08x0m0fBkJ0fwyVhizfPge14rb2cUmEr7+W93VW9Q ggJZzu6EhXNBEwhtbbLwWw8LIhmSByaO21aSUh7K0nOalrYA22hvn9B1ypfoXMGBVYad dIeObFQArsk/EewkCBLqTiXJcIHjJOSIZne20ujwqZhy4q6qyC/C2+7hKlnkDYcAa3A4 AA8GJFrm1xgoHAaTJB89m4Q6ExLiQDDsnJMWKbWee5RcOeLQAdnzCrSFXaPWR+suJ5VL +aIxNDS+7VQae5srW4GfOcI+yyjenMoVZNBn9cJAads9pAIAv7OWdMshwYoSObfLUYSI QnYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790223370; x=1790828170; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pLR8sISmsxHCx8KzZxnkzJcWho2PP8br9Rps/xb8c2M=; b=uXBNLNXLvPRZzPDkEPlJDDt7I1+YJjvVNbNoqen0otwQcbdpYmDNQdiFYSSJ/yzWmP UamQUSJxV1/ml/FJ/ZBv0eO9K65mw2dj1Q3Cr4WywYxgMGlRkYQ7oDun9niPcR2lwgtf K6FMrXdC+/Labq+K1CdDqR1/1i8r9mpJqUEiHfLEgdYpPgWGraQj4saiDOLWNbZ/iPp1 6Y9SMos/uJ0fqUvlQxnj7OEQkLNjQHsGI9aAsH/aTiI9+8glJqYmCx7K9fpUhweKcuuM qm3Aq8Kw/CWsQn0h9KHzrrQO4tsx6XNDx0UnopXXLEiCeBkemxptRN96akvyJojcvedr 3mLw== X-Forwarded-Encrypted: i=1; AKwUvBwI62Uqe7RjvhnD2+IUCBTeoEsDf4YzdH12znGuDAD5hJJy3wQrS8pYwhMjZAwgdlez2pTc@lists.linux.dev X-Gm-Message-State: AFuF++mY5wNYEX4/AmRRM6vhbzRyxBcfuqvq4+og2PoxpKbdO0mIFUr8 XdbGPwE9vaPsW8tRwxjY4+xoljEE6rxK3rfCHJXb3xUzzg5DxfcmOXJOy+0QsQz6z/jgutZ/pO4 UsC+5Eg== X-Received: from jabfl2.prod.google.com ([2002:a05:6638:63c2:b0:5f4:158f:39f2]) (user=avagin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:16a1:b0:4d6:85d4:8499 with SMTP id 5614622812f47-4d728922d24mr1384307b6e.7.1790223369945; Wed, 23 Sep 2026 21:16:09 -0700 (PDT) Date: Thu, 24 Sep 2026 04:16:00 +0000 In-Reply-To: <20260924041604.3209659-1-avagin@google.com> Precedence: bulk X-Mailing-List: criu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260924041604.3209659-1-avagin@google.com> X-Mailer: git-send-email 2.56.0.rc1.310.g51773c2048-goog Message-ID: <20260924041604.3209659-5-avagin@google.com> Subject: [PATCH 4/7] x86/fpu: Document reasoning of FX-only fallback From: Andrei Vagin To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Chang S. Bae" Cc: linux-kernel@vger.kernel.org, criu@lists.linux.dev, Dave Hansen , x86@kernel.org, Andrei Vagin , Alexander Mikhalitsyn , "H. Peter Anvin" Content-Type: text/plain; charset="UTF-8" Add a comment to check_xstate_in_sigframe() to explain the reasoning behind falling back to the FX-only state when signal frame metadata is inconsistent. The fallback is intended to preserve backward compatibility with legacy user-space processes that are not aware of XSAVE states and might only fill or copy the legacy FP state. However, this fallback should be avoided whenever possible. If a process was actively using extended features, falling back to the FX-only state silently resets those extended registers to their initial state, which can lead to silent user-space state corruption. Reviewed-by: Alexander Mikhalitsyn Reviewed-by: Chang S. Bae Signed-off-by: Andrei Vagin --- arch/x86/kernel/fpu/signal.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c index b9dcd0cd0e41..d56819fe491e 100644 --- a/arch/x86/kernel/fpu/signal.c +++ b/arch/x86/kernel/fpu/signal.c @@ -54,6 +54,14 @@ static inline bool check_xstate_in_sigframe(struct fxregs_state __user *buf_fx, if (likely(magic2 == FP_XSTATE_MAGIC2)) return true; err_setfx: + /* + * The fallback to FX-only state is used to preserve backward + * compatibility with user-space processes that are not aware of xsave + * states. + * + * In all other cases, returning false (to trigger SIGSEGV) is + * preferred to avoid silent user-space state corruption. + */ trace_x86_fpu_xstate_check_failed(x86_task_fpu(current)); /* Set the parameters for fx only state */ -- 2.56.0.rc1.310.g51773c2048-goog