Re: [PATCH] leds: trigger: input-events: Restore previous brightness on input

[sashiko-bot@kernel.org]

> From: Nikolay Plastinin <plaztininikolai@gmail.com>
> 
> The trigger turns the LEDs back on with LED_FULL, which the LED core
> clamps to max_brightness. For keyboard backlights with several levels,
> such as asus::kbd_backlight, this means the backlight always comes back
> at maximum after being idle instead of at the level the user picked.
> 
> Remember the brightness in blink_brightness before turning the LEDs off
> and use it when turning them back on, as the netdev trigger does.
> Brightness changes made while the trigger is active are picked up too.
> This needs per-LED handling, so convert the trigger from the simple
> trigger API to a regular trigger with an activate callback.
> 
> Tested on an ASUS ROG Flow X13 GV302XV: with the keyboard backlight at
> level 1, it now comes back at level 1 after going idle instead of at 3.
> A level changed with the brightness hotkeys while the trigger is active
> is restored after the next idle period as well.
> 
> Assisted-by: Claude Opus 5.5
> Signed-off-by: Nikolay Plastinin <plaztininikolai@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-leds-input-events-brightness-v1-1-b0ceff3a2343@gmail.com?part=1