From: Jakub Kicinski <kuba@kernel.org>
To: Quanye Yang via B4 Relay <devnull+quanyeyang.proton.me@kernel.org>
Cc: quanyeyang@proton.me, Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
Geliang Tang <geliang@kernel.org>,
Mat Martineau <martineau@kernel.org>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/2] tcp: annotate lockless access to sk->sk_err
Date: Thu, 24 Sep 2026 08:10:27 -0700 [thread overview]
Message-ID: <20260924081027.28b39617@kernel.org> (raw)
In-Reply-To: <20260917-mptcp-sk-err-net-v4-1-1f04f52f2561@proton.me>
On Thu, 17 Sep 2026 06:41:22 -0700 Quanye Yang via B4 Relay wrote:
> - if (sk->sk_err) {
> + if (READ_ONCE(sk->sk_err)) {
> ret = sock_error(sk);
This sort of construct needs to be de-sillified in both patches.
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-24 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:41 [PATCH net-next v4 0/2] tcp: annotate lockless access to sk->sk_err Quanye Yang via B4 Relay
2026-09-17 13:41 ` Quanye Yang
2026-09-17 13:41 ` [PATCH net-next v4 1/2] " Quanye Yang via B4 Relay
2026-09-17 13:41 ` Quanye Yang
2026-09-18 9:51 ` David Laight
2026-09-18 10:33 ` quanyeyang
2026-09-18 12:27 ` David Laight
2026-09-18 14:49 ` quanyeyang
2026-09-21 14:10 ` netdev-bot+sashiko
2026-09-25 4:31 ` quanyeyang
2026-09-24 15:10 ` Jakub Kicinski [this message]
2026-09-17 13:41 ` [PATCH net-next v4 2/2] mptcp: " Quanye Yang via B4 Relay
2026-09-17 13:41 ` Quanye Yang
2026-09-18 11:28 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924081027.28b39617@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=devnull+quanyeyang.proton.me@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quanyeyang@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.