Re: [PATCH net-next 03/13] net/mlx5: LAG, allocate v2p_map dynamically

[sashiko-bot@kernel.org]

> From: Shay Drory <shayd@nvidia.com>
> 
> v2p_map was a fixed array sized MLX5_MAX_PORTS *
> MLX5_LAG_MAX_HASH_BUCKETS embedded in struct mlx5_lag. Turn it into a
> pointer allocated in mlx5_lag_dev_alloc() once ldev->ports is known,
> sized by the actual port count, and free it in mlx5_ldev_free(). The
> ldev->ports / ldev->buckets initialization is moved up so the allocation
> can use it.
> 
> The matching scratch buffer in mlx5_modify_lag() is converted from a
> MLX5_MAX_PORTS-sized stack array to a kcalloc() of the same extent, with
> the trailing teardown reworked through a goto so the buffer is freed on
> every path. The memcpy() that previously relied on sizeof() of the stack
> array now uses the explicit ldev->ports * MLX5_LAG_MAX_HASH_BUCKETS
> span.
> 
> No functional change; this removes v2p_map's dependency on
> MLX5_MAX_PORTS.
> 
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
> Reviewed-by: Akiva Goldberger <agoldberger@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923103830.1183-1-tariqt@nvidia.com?part=3