From: sashiko-bot@kernel.org
To: "Guangshuo Li" <lgs201920130244@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: ma35d1: unmap MMIO on remove
Date: Thu, 24 Sep 2026 11:11:05 +0000 [thread overview]
Message-ID: <20260924111105.9287A1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924110400.1556396-1-lgs201920130244@gmail.com>
> ma35d1serial_probe() maps up->port.membase with ioremap(), but
> ma35d1serial_remove() does not perform the matching iounmap(). The probe
> error path already releases this mapping after disabling the clock.
>
> Add iounmap() to the remove path after clk_disable_unprepare() to match
> the resource cleanup order used by ma35d1serial_probe().
>
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924110400.1556396-1-lgs201920130244@gmail.com?part=1
next prev parent reply other threads:[~2026-09-24 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 11:04 [PATCH] serial: ma35d1: unmap MMIO on remove Guangshuo Li
2026-09-24 11:11 ` sashiko-bot [this message]
2026-10-01 8:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924111105.9287A1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.