From: Simon Horman <horms@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: benquike@gmail.com, dsahern@kernel.org, idosch@nvidia.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, alex.aring@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: exthdrs: copy old IPv6 header before skb_mac_header_rebuild() in ipv6_rpl_srh_rcv()
Date: Thu, 24 Sep 2026 12:24:34 +0100 [thread overview]
Message-ID: <20260924112434.GC13925@horms.kernel.org> (raw)
In-Reply-To: <179017599653.2160803.10920272565185423743@kernel.org>
On Wed, Sep 23, 2026 at 03:06:36PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 (1) · Medium: 1 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
The above requires a response.
But as there is none, I will try to move things along.
> - [High] Incomplete/inverted fix in ipv6_rpl_srh_rcv()
> (net/ipv6/exthdrs.c): moving `memmove(skb->data, oldhdr, sizeof(struct…
This [High] issues to seem to need to be addressed and the suggestion that
accompanies the issue seems sensible to me.
> - [Medium] Commit message inaccuracies plus an undisclosed functional
> change.
And as given the presence of the [High] issue this one may as well be fixed
too.
>
> Pre-existing issues:
> - [High] ipv6_rpl_srh_rcv() (net/ipv6/exthdrs.c) mutates the skb data
> area without ever guaranteeing exclusive ownership of it, unlike every…
This seems to be a real problem but orthogonal to this patch.
I would suggest that it likely exists elsewhere too.
--
pw-bot: changes-requested
prev parent reply other threads:[~2026-09-24 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 21:06 [PATCH] ipv6: exthdrs: copy old IPv6 header before skb_mac_header_rebuild() in ipv6_rpl_srh_rcv() Hui Peng
2026-09-21 15:14 ` krzk
2026-09-23 15:06 ` netdev-bot+sashiko
2026-09-24 11:24 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924112434.GC13925@horms.kernel.org \
--to=horms@kernel.org \
--cc=alex.aring@gmail.com \
--cc=benquike@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.