Re: [LTP] [PATCH] lib: tst_test: Clarify the .needs_abi_bit TCONF message

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

> The previous message was confusing. On 32bit machine sendfile09 tests
> that has .needs_abi_bits = 64 produced this message:

> tst_test.c:1493: TCONF: 64bit ABI is not supported

> This message is a bit confusing, since on 32bit x86 machine 64bit ABI
> is, of course, not supported, so why do we skip the test?

> After this patch the message is:

> tst_test.c:1493: Test needs 64bit ABI

> Which is, as far as I can tell, more clear.

+1, sure, merge before release.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> Fixes: 56f63e54e5a3 ("lib: Add .needs_abi_bits")
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>  lib/tst_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index ed3d26cad..e27a24c24 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -1490,7 +1490,7 @@ static void do_setup(int argc, char *argv[])
>  		tst_brk(TCONF, "Not supported in 32-bit compat mode");

>  	if (tst_test->needs_abi_bits && !tst_abi_bits(tst_test->needs_abi_bits))
> -		tst_brk(TCONF, "%dbit ABI is not supported", tst_test->needs_abi_bits);
> +		tst_brk(TCONF, "Test needs %dbit ABI", tst_test->needs_abi_bits);

>  	if (tst_test->needs_cmds) {
>  		struct tst_cmd *pcmd = tst_test->needs_cmds;

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp