Re: [PATCH v2 3/9] dt-bindings: media: snps,dw-hdmi-rx: add a port for a bridge in front

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: snps,dw-hdmi-rx: oneOf prevents valid port+gpio topologies
--

commit 5a7ff8edccb5f40d2e32f33eaa88727a0083785a
Author: Sascha Hauer <s.hauer@pengutronix.de>

dt-bindings: media: snps,dw-hdmi-rx: add a port for a bridge in front

This commit describes the OF graph port for connecting an HDMI bridge in
front of the receiver. It enforces a mutually exclusive constraint where a 
board must provide exactly one of hpd-gpios or port.

> diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> index b7f6c87d0e06a..896f8ffbb5bf9 100644
> --- a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
[ ... ]
> @@ -88,7 +100,12 @@ required:
>    - power-domains
>    - resets
>    - pinctrl-0
> -  - hpd-gpios
> +
> +oneOf:
> +  - required:
> +      - hpd-gpios
> +  - required:
> +      - port

[Severity: Medium]
Does this strict XOR constraint break validation for boards that need to define
both properties?

A board might route high-speed video through an upstream bridge (which requires
the port) while still wiring the HDMI +5V detect line directly to an SoC GPIO
(which requires hpd-gpios). Similarly, standard DT architecture for direct HDMI
connections encourages explicit hdmi-connector nodes linked via the port, which
would also necessitate retaining hpd-gpios on the controller for 5V sensing.

Although the driver implementation might gracefully handle both properties being
present simultaneously, this schema constraint forbids valid hardware topologies
from passing dt_binding_check. Would it be more appropriate to use anyOf here
to allow one or both properties?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-hdmirx-media-v2-0-c12f641d8b0f@pengutronix.de?part=3